Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(micro-server): make statusCode in ReplySuccessContent optional #157

Merged
merged 2 commits into from
May 22, 2022
Merged

feat(micro-server): make statusCode in ReplySuccessContent optional #157

merged 2 commits into from
May 22, 2022

Conversation

mohammadhonarvar
Copy link
Member

Description

Make a change in the type of ReplySuccessContent

@mohammadhonarvar mohammadhonarvar requested a review from alimd May 22, 2022 15:09
@mohammadhonarvar mohammadhonarvar self-assigned this May 22, 2022
@alimd alimd requested review from alimd and removed request for alimd May 22, 2022 15:16
@alimd alimd added the enhancement Enhancement of the code, not introducing new features. label May 22, 2022
@alimd alimd added this to the v1.0.0-beta milestone May 22, 2022
alimd
alimd approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alimd alimd merged commit 6d46f42 into next May 22, 2022
@alimd alimd deleted the feature/micro-server-statusCode branch May 22, 2022 18:54
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alimd alimd alimd approved these changes

Assignees

@mohammadhonarvar mohammadhonarvar

Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
v0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammadhonarvar @alimd