Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: transform eslint config to json #144

Merged
merged 3 commits into from
Apr 19, 2022
Merged

chore: transform eslint config to json #144

merged 3 commits into from
Apr 19, 2022

Conversation

amir25n
Copy link
Member

@amir25n amir25n commented Apr 19, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #(issue)

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@amir25n amir25n requested a review from MM25Zamanian April 19, 2022 11:12
@amir25n
Copy link
Member Author

amir25n commented Apr 19, 2022

@alimd ok?

MM25Zamanian
MM25Zamanian approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@MM25Zamanian MM25Zamanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always is Ok! Thanks🌹

@MM25Zamanian MM25Zamanian requested a review from alimd April 19, 2022 11:18
alimd
alimd approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

alimd
alimd requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

چرا تب ها ۴ تایی هستش!
مگه تنظیمات pritier لود نیست؟

(قرار نیست تمام بشه)

@alimd alimd changed the title Feat/lint chore: transform yaml to json Apr 19, 2022
@alimd alimd changed the title chore: transform yaml to json chore: transform eslint config to json Apr 19, 2022
@alimd alimd merged commit 72a6de2 into next Apr 19, 2022
@alimd alimd deleted the feat/lint branch April 19, 2022 16:04
@alimd alimd self-assigned this Apr 19, 2022
@alimd alimd added the enhancement Enhancement of the code, not introducing new features. label Apr 19, 2022
@alimd alimd added this to the v1.0.0-beta milestone Apr 19, 2022
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alimd alimd alimd approved these changes

@MM25Zamanian MM25Zamanian MM25Zamanian approved these changes

Assignees

@alimd alimd

Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
v0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@amir25n @alimd @MM25Zamanian