Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove impl trait from parameter positions in Marshaller write methods #135

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

samsarge
Copy link
Contributor

@samsarge samsarge commented Feb 4, 2025

Warning can potentially cause breaking changes when using the BytecodeWrite trait

#133

Also remove from trait defintion - warning this can cause breaking changes
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.5%. Comparing base (2fba304) to head (0693535).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/library/marshaller.rs 57.1% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #135   +/-   ##
======================================
  Coverage    61.5%   61.5%           
======================================
  Files          17      17           
  Lines        1073    1073           
======================================
  Hits          660     660           
  Misses        413     413           
Flag Coverage Δ
rust 61.5% <57.1%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky added this to the v0.12.0 milestone Feb 5, 2025
@dr-orlovsky dr-orlovsky linked an issue Feb 5, 2025 that may be closed by this pull request
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0693535

@dr-orlovsky
Copy link
Member

Yes, this is it! Congrats with the first contribution - and thank you for your help!

@dr-orlovsky dr-orlovsky merged commit b5a5452 into AluVM:master Feb 5, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove impl Into<u*> from Marshaller write methods
2 participants