chore(e2etests):

[dagfinno]

The orgNumbers in yt01 are 'scrambled', meaning we for some cases can't use same orgNumbers in yt01 as in other environments

Related Issue(s)

• Adjust thresholds for CI smoke tests #1862

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces a conditional constant activityActorId in the common configuration file, which assigns different values based on the __ENV.API_ENVIRONMENT variable. It updates test files by replacing hardcoded actor identifiers with the dynamic activityActorId and simplifies the cleanUp function in one test file by removing unnecessary filtering logic. The changes ensure that tests use environment-dependent values, aligning static test data with dynamic configuration.

Changes

File(s)	Summary of Changes
tests/k6/common/config.js	Added new exported constant activityActorId that conditionally assigns values based on __ENV.API_ENVIRONMENT; also inserted an extra blank line.
tests/k6/tests/performancetest_data/01-create-dialog.js	Removed several lines in the cleanUp function including the ACTIVITY_TYPE_INFORMATION constant, payload destructuring for visibleFrom, and the activity mapping logic; now returns the payload unmodified.
tests/k6/tests/serviceowner/testdata/01-create-dialog.js	Updated the import statement to include activityActorId from the common config; modified the actorId in the activities array to use a dynamic concatenation with activityActorId instead of a hardcoded string.

Possibly related PRs

• chore: refactor production deployment flow #1771: Introduces similar changes by updating the actorId field to use activityActorId, showing a code-level connection.
• chore(performance): tweaked thresholds #1881: Modifies the activities array to adopt the new dynamic activityActorId, directly relating to changes in this PR.
• chore(performance): Add correct permissions to ci-cd-yt01 #1873: Updates the configuration to use activityActorId in constructing the actorId, establishing a clear code-level link.

Suggested reviewers

• oskogstad

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

tests/k6/common/config.js (2)

69-69: Document the significance of the yt01-specific organization number.

The organization number "713431400" appears to be specific to the yt01 environment. Consider adding a comment explaining its significance or defining it as a named constant for better maintainability.

+// Organization number for yt01 environment
+const YT01_SERVICE_OWNER_ORG_NO = "713431400";
 export const activityActorId = __ENV.API_ENVIRONMENT == "yt01" ? 
-  "713431400" : 
+  YT01_SERVICE_OWNER_ORG_NO :
   "991825827";

---

69-69: Consider reusing defaultServiceOwnerOrgNo constant.

For non-yt01 environments, consider reusing the defaultServiceOwnerOrgNo constant instead of duplicating the value "991825827".

-export const activityActorId = __ENV.API_ENVIRONMENT == "yt01" ? "713431400" : "991825827";
+export const activityActorId = __ENV.API_ENVIRONMENT == "yt01" ? "713431400" : defaultServiceOwnerOrgNo;

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93b953c and 73f9545.

📒 Files selected for processing (3)

• tests/k6/common/config.js (1 hunks)
• tests/k6/tests/performancetest_data/01-create-dialog.js (1 hunks)
• tests/k6/tests/serviceowner/testdata/01-create-dialog.js (2 hunks)

🔇 Additional comments (2)

tests/k6/tests/serviceowner/testdata/01-create-dialog.js (1)

2-2: LGTM! Good use of environment-specific configuration.

The changes correctly implement environment-specific actor IDs by:

1. Importing the new activityActorId constant
2. Using it to dynamically construct the URN for the activity performer

Also applies to: 304-304

tests/k6/tests/performancetest_data/01-create-dialog.js (1)

4-14: LGTM! Good simplification of the cleanup function.

The function has been simplified while maintaining:

1. Input validation
2. Sentinel tag addition for test cleanup
3. Immutable payload handling