Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests to EU-API with only digdir:dialogporten.noconsent fails with 500 #1675

Open
elsand opened this issue Jan 10, 2025 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@elsand
Copy link
Member

elsand commented Jan 10, 2025

Description

Use of the digdir:dialogporten.noconsent scope is broken; for the EU API to work, the digdir:dialogporten must currently also be supplied. This will (or rather, should) cause a consent-dialog to be shown in ID-porten.

Reproduction

  1. Fetch a ID-porten with only digdir:dialogporten.noconsent
  2. Attempt any request to any EU API endpoint

Expected behavior

The Dialogporten API should return a valid result

Actual behavior

The Dialogporten API returns a 500 Internal Server Error

Additional information

The digdir:dialogporten scope is currently configured to not show a consent dialog in ID-porten test. This is incorrect, but has been done as a workaround for this bug. As soon as this bug is fixed, the scope should be configured to require consent again (it is correctly configured in ID-porten prod)

@elsand elsand added the bug Something isn't working label Jan 10, 2025
@elsand elsand moved this from New issues to Ready in Dialogporten / Arbeidsflate Jan 10, 2025
@oskogstad oskogstad self-assigned this Jan 22, 2025
@oskogstad oskogstad moved this from Ready to Doing in Dialogporten / Arbeidsflate Jan 22, 2025
oskogstad added a commit that referenced this issue Jan 29, 2025
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1675 
- #1160 


## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@oskogstad oskogstad moved this from Doing to Testing in Dialogporten / Arbeidsflate Jan 30, 2025
oskogstad added a commit that referenced this issue Jan 30, 2025
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1675

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@LeifHelstad
Copy link

Test

Setter denne mer tekniske beskrivelsen til Teststatus = NA da den mer funksjonelle varianten allerede er prod-verifisert, slik det er beskrevet i Altinn/dialogporten-frontend#1672

@LeifHelstad
Copy link

LeifHelstad commented Feb 12, 2025

@elsand hvis jeg ikke har misforstått sa var dette var en "prodfeil" som ble rettet nokså umiddelbart.
Ref:

Hvis du er enig kan denne "ryddes" fra Testing til Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Testing
Development

No branches or pull requests

3 participants