Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger definition missing type for ETag headers #1665

Closed
oskogstad opened this issue Jan 8, 2025 · 5 comments
Closed

Swagger definition missing type for ETag headers #1665

oskogstad opened this issue Jan 8, 2025 · 5 comments
Assignees
@oskogstad @knuhau
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

Swagger definition missing type for ETag headers

              "Etag": {
                "description": "The new UUID ETag of the dialog",
                "example": "123e4567-e89b-12d3-a456-426614174000",
                "schema": {
                  "type": "string"
                }
              }
@oskogstad oskogstad added the bug Something isn't working label Jan 8, 2025
@oskogstad oskogstad mentioned this issue Jan 8, 2025
Merged
4 tasks
oskogstad added a commit that referenced this issue Jan 8, 2025
@oskogstad @knuhau
fix(webi): Add missing type on ETag response headers (#1666)
df559ed 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1665 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)

Co-authored-by: Knut Haug <[email protected]>
@LeifHelstad
Copy link

LeifHelstad commented Jan 13, 2025 •
edited
Loading

Test

Er dette en del av "besviset" for at Etag nå har type?

Image

Image

@oskogstad
Copy link
Collaborator Author

Ja, swaggeren vår feilet validering på https://editor.swagger.io/

@LeifHelstad
Copy link

@oskogstad skal eller kan ETag være en del av request body?

@oskogstad
Copy link
Collaborator Author

@LeifHelstad Nei, på requests er det If-Match (header), på response er det Etag

@LeifHelstad
Copy link

Test

Bildene i min 5t gamle kommentar viser at Swagger validerer ok nå.

@elsand elsand moved this from Testing to Done in Dialogporten / Arbeidsflate Jan 15, 2025
@elsand elsand closed this as completed by moving to Done in Dialogporten / Arbeidsflate Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

@knuhau knuhau

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elsand @oskogstad @knuhau @LeifHelstad