Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing FCE in transmissions content #1273

Closed
elsand opened this issue Oct 11, 2024 · 4 comments
Closed

Missing FCE in transmissions content #1273

elsand opened this issue Oct 11, 2024 · 4 comments
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@elsand
Copy link
Member

elsand commented Oct 11, 2024

Description

Transmissions content should have a FCE like "MainContentReference"

Expected behavior

A FCE field akin to "MainContentReference" called just "ContentReference" should be available

Actual behavior

It isn't
@elsand elsand added the bug Something isn't working label Oct 11, 2024
@oskogstad oskogstad self-assigned this Oct 11, 2024
@oskogstad oskogstad mentioned this issue Oct 11, 2024
Merged
4 tasks
@oskogstad
Copy link
Collaborator

@elsand should this transmission FCE also support legacy HTML? 🤔
Or would that all be covered by the dialog main content?

@elsand
Copy link
Member Author

elsand commented Oct 12, 2024

@elsand should this transmission FCE also support legacy HTML? 🤔 Or would that all be covered by the dialog main content?

Not a requirement as of now, but no need to add code to deny it either.

@elsand elsand closed this as completed Oct 14, 2024
oskogstad added a commit that referenced this issue Oct 14, 2024
@oskogstad
fix(webAPI): Allow front channel embeds on TransmissionContent (#1276)
c87e8f4 
<!--- Provide a general summary of your changes in the Title above -->

## Description

* Adds missing XML comments for OpenAPI spec on transmissions
* Adds support for front channel embeds on transmission content
* Adds tests for transmission creation

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1273 

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Added a new field `contentReference` to the `TransmissionContent`
type, allowing for additional content references.
- Enhanced various schemas with new properties, including
`contentReference` and improved descriptions for clarity.
- Introduced new properties in multiple DTOs to support dynamic content
embedding and improved data structure.

- **Bug Fixes**
- Updated validation rules for `mainContentReference` to ensure
compliance with specified constraints.

- **Tests**
- Added integration tests for the `Create` command in the ServiceOwner
feature to validate transmission creation functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@LeifHelstad
Copy link

LeifHelstad commented Nov 5, 2024 •
edited
Loading

Testdata for negativ test, detter er html content, ikke content reference:

image

I dette tilfellet la jeg contentReference utenfor content, dermed ble den liggende et sted i strukturen der den ble ignorert.

@LeifHelstad
Copy link

LeifHelstad commented Nov 5, 2024 •
edited
Loading

Negativ test er gjennomført ved å ha contentReference på rett plass under tranmissions+content.

  1. med mediaType som nektes
  • text/html
  • application/vnd.dialogporten.frontchannelembed+json;type=html
  1. med value som ikke er URL

Positiv test er utført med:
"mediaType": "application/vnd.dialogporten.frontchannelembed+json;type=markdown"
"value": "https://dialogporten-serviceprovider-ahb4fkchhgceevej.norwayeast-01.azurewebsites.net/fce"

Dette kan leses tilbake med get og dialog-id. Test er passed.
Transmissions kan foreløpig ikke testes via arbeidsflate, så den ekstra verifiseringen er ikke gjort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elsand @oskogstad @LeifHelstad