Implement Altinn Platform Storage Integration PoC

[elsand]

Introduction

This lays the groundwork for the solution outlined in #56 on the Dialogporten end.

The purpose of this PoC is to determine whether or not we have the data available for a basic, automatic integration and if the overall solution is feasible. After the PoC is done, we should have more information about how to move forward (do we need additional changes in storage, and/or changes in Studio?)

Description

See #56 for details.

In this PoC, we want to attempt to

• Establish a git repository for the new component
• Set up a ASP.NET application
• Expose a Maskinporten-secured endpoint that takes a instance-id and app reference
• Perform API requests to storage fetching instance and app metadata
• Map the current state to a dialog
• Create, update or delete the dialog using Dialogporten APIs

Out of scope:

• Establishing a message bus
• Message production in storage based on instance state changing events
• Introducing admin scope for accessing any instance data (limited to Digdir/TTD apps in PoC)

Implementation

In order to support migration scenarios, we need to be able to map any given instance in any state (even without the corresponding app existing, save the application metadata) to a dialog. Each of the main state transitions (creation, archival, deletion) should add some sort of activity log entry. In addition, instance events should be mapped to activity history entries. Only a subset is relevant (ie. not every Save operation).

Deletion

Deleting from dialogporten are implemented as write actions, which require as dialog token enabled endpoint to access. This must be implemented and provided by dialogporten-adapter, which will verify the request via the dialog token and, if valid, proxy a deletion request to storage. This will (when implemented) trigger an event from storage to the adapter, which will in turn delete the dialog in Dialogporten. For the PoC, the adapter should dual write the deletion request to Dialogporten directly.

Tasks

Preview Give feedback

1. Establish repository inn altinn-org on Github and docker image build actions
2. Set up basic application and wiring, including docker image
3. Expose endpoint for receving instance-id and app reference
4. Implement Storage API client
5. Implement Dialogporten API client
6. Implement mapping logic
7. Implement dialogtoken-secured endpoint to proxy deletion requests to storage
8. Add monitoring
9. A3 integration: infrastructure and deploy #1594
   1 of 2
   +0
   
10. Add additional activity log types #1588
    2 of 2
    +0
    
11. New revision of dialog available in response header after change #1611
    1 of 4
    +0
    
12. Add option to disable event generation #1612
    3 of 5
    +0
    
13. Implement restoration of dialogs #1543
    4 of 4
    +0
    
14. Accept id on attachments, actions when creating dialogs #1623
    5 of 5
    +0
    
15. Eksponere API i Register for Party og Rolleinformasjon altinn-register#233
    +0
    

Threat modelling

Preview Give feedback

1. The endpoint will have to be secured to guard against unauthorized access, but still allow for testing

Acceptance criteria

GIVEN ...
WHEN ....
THEN ...

GIVEN ...
WHEN ....
THEN ...

[MagnusSandgren]

Glenstående aktiviteter:

• API-er fra altinn autorisasjon for å hente ut fnr/orgnr/systemuserid fra partyId/userId (se slack tråd)
• ❎ Utvidelse av GET /storage/api/v1/instances i storage for å sortere på Created desc eller asc (se slack tråd)
• ✅ Utvid DialogActivityType med Submitted og DraftSaved/FormSaved i Dialogporten
• Ta i bruk alle endringene ovenfor i Storage.Platform.DialogpotenAdapter ☝️
• Verifiser dialogtoken på DELETE /api/v1/instance/{instanceId} i Adapter
• Skriv spec for når InstanceEvent skal sendes (ikke send dersom datavalues endres)
• Ta stilling til applicaiton.hideSettings (ref dette)
• Ta stilling til create copy (GuiAction for kopier? kun når instansen er arkivert) (ref dette)
• Ta stilling til størrelsen på den konverterte dialogen slik at vi ikke får 413 payload too large fra dialogporten
  • Hva gjør vi dersom Attachments har for mange elementer?
  • Hva med om Activities har for mange elementer?
• Ta stilling til hva vi gjør med summary. Det er et nødvendig felt i dialogen, men instansene har ingen konsept om summary.
• Statiske LocalizationSet utfordringer:
  • Legg inn engelsk og nynorsk (i tillegg til norsk som ligger der fra før)
  • Templatefisere for å ikke duplisere data i dialogporten?

Gjenstående test oppgaver (ukomplett liste):

• Verifiser at en dialog kan traversere fra Draft til InProgress etter et feedback steg.