Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature flag and new component FormDesignernavigation #14815

Closed
wants to merge 1 commit into from

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Feb 26, 2025

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • New Features

    • Enhanced the editing experience by conditionally displaying a tailored navigation interface based on user preferences and enabled features.
    • Introduced persistence for form layout selection, ensuring a consistent and streamlined design process.
  • Style

    • Applied modern styling enhancements to the new navigation interface for improved visual appeal and usability.
  • Tests

    • Added placeholders to expand test coverage for the navigation components in future updates.

Copy link
Contributor

coderabbitai bot commented Feb 26, 2025

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 39 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6722766 and 02f8d08.

📒 Files selected for processing (6)
  • frontend/app-development/router/routes.tsx (3 hunks)
  • frontend/packages/shared/src/utils/featureToggleUtils.ts (1 hunks)
  • frontend/packages/ux-editor/src/containers/FormDesignNavigation/FormDesignerNavigation.module.css (1 hunks)
  • frontend/packages/ux-editor/src/containers/FormDesignNavigation/FormDesignerNavigation.test.tsx (1 hunks)
  • frontend/packages/ux-editor/src/containers/FormDesignNavigation/FormDesignerNavigation.tsx (1 hunks)
  • frontend/packages/ux-editor/src/containers/FormDesignNavigation/index.ts (1 hunks)
📝 Walkthrough

Walkthrough

This pull request introduces conditional rendering in the UiEditor component by integrating a new feature flag, TaskNavigation. A state variable that uses local storage to retain the layout set name is added alongside a new query for app configuration data. When the flag is enabled and no layout set name is present, the new FormDesignerNavigation component is rendered instead of UiEditorLatest. Additionally, the FeatureFlag enum is updated with the TaskNavigation member, and new component files—with corresponding CSS styles and test placeholders—are added to support form designer navigation.

Changes

File(s) Change Summary
frontend/app-development/router/routes.tsx Updated UiEditor by adding a local storage state, new app config query, and a boolean flag (isTaskNavigationEnabled); implements conditional rendering to switch between FormDesignerNavigation and UiEditorLatest.
frontend/packages/shared/src/utils/featureToggleUtils.ts Extended the FeatureFlag enum by adding a new member: TaskNavigation.
frontend/packages/ux-editor/src/containers/FormDesignNavigation/* Introduced the new FormDesignerNavigation React component with its corresponding CSS module, export statement, and test file updates (including TODO comments for further test coverage).

Possibly related PRs

Suggested labels

added-to-sprint, team/studio-domain1, skip-manual-testing, skip-documentation

Suggested reviewers

  • Jondyr
  • mlqn

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants