fix: disabled delete button

[JamalAlabdullah]

Description

• Disabled delete button in dynamic when there is no expression added.
• Added test for it.

Related Issue(s)

• Disable delete button when there is no expression for dynamic in config panel #14775

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

• New Features
  • The delete button now appears only when a valid expression is present, resulting in a cleaner, more intuitive interface by reducing unnecessary options.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the ExpressionContent component and its tests. The component now conditionally renders the delete button (StudioDeleteButton) only when the expression prop is truthy. The test suite is enhanced with two new tests that verify the delete button's presence when an expression is provided and its absence when not. Additionally, an existing test has been modified to include the expression prop, ensuring the onDelete function is correctly exercised in the testing scenario.

Changes

File(s)	Change Summary
frontend/.../ExpressionContent.tsx, frontend/.../ExpressionContent.test.tsx	Updated ExpressionContent to render the delete button only if the expression prop is provided. Added new tests to verify the button’s visibility when an expression exists and its absence when missing, and adjusted an existing test to include the expression prop.

Suggested labels

area/ui-editor, frontend, skip-manual-testing, skip-documentation

Suggested reviewers

• Jondyr
• github-actions

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09a1dcd and db717db.

📒 Files selected for processing (2)

• frontend/packages/ux-editor/src/components/config/ExpressionContent/ExpressionContent.test.tsx (1 hunks)
• frontend/packages/ux-editor/src/components/config/ExpressionContent/ExpressionContent.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Build environment and run e2e test
• GitHub Check: CodeQL
• GitHub Check: Testing

🔇 Additional comments (2)

frontend/packages/ux-editor/src/components/config/ExpressionContent/ExpressionContent.tsx (1)

51-59: LGTM! The delete button is now correctly hidden when no expression exists.

The conditional rendering of the delete button based on the expression prop is a good UX improvement that prevents users from attempting to delete non-existent expressions.

frontend/packages/ux-editor/src/components/config/ExpressionContent/ExpressionContent.test.tsx (1)

61-61: LGTM! Test coverage is comprehensive and well-structured.

The test suite effectively verifies the delete button's visibility logic:

• Updated existing test to include the expression prop
• Added test for delete button presence when expression exists
• Added test for delete button absence when no expression exists

Also applies to: 68-78

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (0df8045) to head (db717db).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14792      +/-   ##
==========================================
- Coverage   95.76%   95.76%   -0.01%     
==========================================
  Files        1916     1916              
  Lines       24988    24989       +1     
  Branches     2859     2860       +1     
==========================================
  Hits        23930    23930              
  Misses        799      799              
- Partials      259      260       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lassopicasso]

👍

[mlqn]

Nice catch! Tested OK 👍