-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pages-api): create layout service to handle more explicit layout actions #14684
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
71f25b7
to
869c2a5
Compare
31d2f69
to
e886d3a
Compare
869c2a5
to
7b3e19e
Compare
7b3e19e
to
dca3296
Compare
e886d3a
to
18fb83c
Compare
68c5847
to
9c5ef25
Compare
e743118
to
59b0493
Compare
c78bd45
to
b5f260c
Compare
9c5ef25
to
1818a36
Compare
1818a36
to
b76a017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only have two optional suggestions/questions.
backend/src/Designer/Infrastructure/GitRepository/AltinnAppGitRepository.cs
Outdated
Show resolved
Hide resolved
b76a017
to
1d56433
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
1d56433
to
f366d38
Compare
…se layout name Remove file extension formatting on layoutName parameter of service repository layer methods in AltinnAppGitRepository. This makes the method more consistent with the other methods and follows layer responsibilities (service layer does not need to know or specify file extension). # Testing: - [ ] Operations acting on layout sets or layouts should be tested on frontend commit-id:cf35ff23
…yout actions Creates a new service `LayoutService` that will be used for more fine grained explicit operations on the layout configurations. Adds basic operations for pages in a layout. commit-id:d6447eac
f366d38
to
a188a99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK, nice work! 🚀
Description
Creates a new service
LayoutService
that will be used for more finegrained explicit operations on the layout configurations.
Adds basic operations for pages in a layout.
Stack:
Related Issue(s)
Verification
Documentation