Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pages-api): create layout service to handle more explicit layout actions #14684

Merged
merged 8 commits into from
Mar 4, 2025

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Feb 17, 2025

Description

Creates a new service LayoutService that will be used for more fine
grained explicit operations on the layout configurations.
Adds basic operations for pages in a layout.


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link
Contributor

coderabbitai bot commented Feb 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Feb 17, 2025
@Jondyr Jondyr linked an issue Feb 17, 2025 that may be closed by this pull request
4 tasks
@Jondyr Jondyr force-pushed the spr/main/d6447eac branch 3 times, most recently from 71f25b7 to 869c2a5 Compare February 17, 2025 12:47
@Jondyr Jondyr force-pushed the spr/main/d6447eac branch 3 times, most recently from 68c5847 to 9c5ef25 Compare February 18, 2025 14:43
@Jondyr Jondyr changed the title refactor: create layout service to handle more explicit layout actions refactor(pages-api): create layout service to handle more explicit layout actions Feb 18, 2025
@lassopicasso lassopicasso self-assigned this Feb 19, 2025
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only have two optional suggestions/questions.

@lassopicasso lassopicasso assigned Jondyr and unassigned lassopicasso Feb 19, 2025
@Jondyr Jondyr assigned lassopicasso and unassigned Jondyr Feb 19, 2025
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

…se layout name

Remove file extension formatting on layoutName parameter of service
repository layer methods in AltinnAppGitRepository. This makes the
method more consistent with the other methods and follows layer
responsibilities (service layer does not need to know or specify file
extension).

# Testing:
- [ ] Operations acting on layout sets or layouts should be tested on
frontend

commit-id:cf35ff23
…yout actions

Creates a new service `LayoutService` that will be used for more fine
grained explicit operations on the layout configurations.
Adds basic operations for pages in a layout.

commit-id:d6447eac
@Jondyr Jondyr removed a link to an issue Feb 26, 2025
4 tasks
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK, nice work! 🚀

Base automatically changed from spr/main/cf35ff23 to main March 4, 2025 07:38
@Jondyr Jondyr merged commit eee62fc into main Mar 4, 2025
8 checks passed
@Jondyr Jondyr deleted the spr/main/d6447eac branch March 4, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants