-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: codeListService #14647
refactor: codeListService #14647
Conversation
- Rename variables to use `codeList` over `option`. - Make `GetCodeListIds` and `GetCodeList` methods private
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work making separate PRs! Makes it very easy to review.
I see you have used the term code-list
. It should be code list
in two words 🙂
Example from documentation
A simple find and replace should fix that right up 🙂
Description
Refactor CodeListService
codeList
and notoption
.GetCodeListIds
andGetCodeList
into private methodsRelated Issue(s)
Additional information
There are no tests in this PR as we're missing required setup for testing endpoints on org level. It will be done in a different PR.
Verification