Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make key icon horizontal and remove unwanted colons in process page #14638

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

ErlingHauan
Copy link
Contributor

@ErlingHauan ErlingHauan commented Feb 11, 2025

Description

Replaces KeyVerticalIcon with KeyHorizontalIcon, and removes unneeded colons from the Prosess page.
The KeyHorizontalIcon change is also reflected on the Utforming page when changing layout name.

Before picture

bilde

After picture

bilde

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

Summary by CodeRabbit

  • Style
    • Refined interface text by simplifying labels for improved clarity and consistency.
    • Updated the default icon in a text field component to offer a refreshed, modern visual appearance.
  • Bug Fixes
    • Adjusted text retrieval in the configuration panel to align with updated label formats, enhancing visibility checks.

Copy link
Contributor

coderabbitai bot commented Feb 11, 2025

Warning

Rate limit exceeded

@TomasEng has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1a8795d and 3e60f4c.

📒 Files selected for processing (1)
  • frontend/language/src/nb.json (2 hunks)
📝 Walkthrough

Walkthrough

This pull request introduces modifications to a localization file (nb.json) by removing trailing colons from specific label strings. Additionally, it updates the StudioToggleableTextfield component by replacing the default icon from KeyVerticalIcon to KeyHorizontalIcon, while maintaining the component’s existing logic and functionality. Furthermore, a method in the ProcessEditorPage class is adjusted to reflect the updated label format by removing a colon from a string being searched.

Changes

File(s) Summary
frontend/language/src/nb.json Removed trailing colons from label values for keys: process_editor.configuration_panel_actions_action_label, process_editor.configuration_panel_name_label, and process_editor.configuration_panel_set_data_model_label.
frontend/libs/studio-components/.../StudioToggleableTextfield.tsx Replaced the default icon from KeyVerticalIcon to KeyHorizontalIcon in the toggleable text field component while retaining existing component behavior.
frontend/testing/playwright/pages/.../ProcessEditorPage.ts Updated the waitForTaskToBeVisibleInConfigPanel method to remove a colon from the text being searched for in the configuration panel.

Possibly related PRs

Suggested labels

area/ui-editor, kind/bug, skip-manual-testing

Suggested reviewers

  • Jondyr

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ErlingHauan ErlingHauan changed the title make key icon horizontal and remove unwanted colons fix: make key icon horizontal and remove unwanted colons in process page Feb 11, 2025
@ErlingHauan ErlingHauan linked an issue Feb 11, 2025 that may be closed by this pull request
@ErlingHauan ErlingHauan marked this pull request as ready for review February 11, 2025 13:02
@ErlingHauan
Copy link
Contributor Author

@Annikenkbrathen I noticed that the insides of the accordions have more spacing than the content above the accordions. Is that something we should look at now? 😊

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.75%. Comparing base (2badc34) to head (3e60f4c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14638   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files        1913     1913           
  Lines       24925    24925           
  Branches     2848     2848           
=======================================
  Hits        23868    23868           
  Misses        799      799           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Annikenkbrathen
Copy link

Annikenkbrathen commented Feb 11, 2025

Is that something we should look at now? 😊

Hmmm no, we can fix the spacing later when we clean up the content in each accordion and make the main-settings area in the config panel.

@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Feb 12, 2025
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok, nice work 👍

@Konrad-Simso Konrad-Simso merged commit f2a6c5c into main Feb 13, 2025
18 checks passed
@Konrad-Simso Konrad-Simso deleted the horizontal-key-icon branch February 13, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1 ux UX help needed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Improve design of Studio components
4 participants