-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make key icon horizontal and remove unwanted colons in process page #14638
Conversation
Warning Rate limit exceeded@TomasEng has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 15 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request introduces modifications to a localization file ( Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@Annikenkbrathen I noticed that the insides of the accordions have more spacing than the content above the accordions. Is that something we should look at now? 😊 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14638 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 1913 1913
Lines 24925 24925
Branches 2848 2848
=======================================
Hits 23868 23868
Misses 799 799
Partials 258 258 ☔ View full report in Codecov by Sentry. |
Hmmm no, we can fix the spacing later when we clean up the content in each accordion and make the main-settings area in the config panel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ok, nice work 👍
Description
Replaces
KeyVerticalIcon
withKeyHorizontalIcon
, and removes unneeded colons from the Prosess page.The
KeyHorizontalIcon
change is also reflected on the Utforming page when changing layout name.Before picture
After picture
Related Issue(s)
Verification
Summary by CodeRabbit