-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update supported component types #14566
Conversation
📝 WalkthroughWalkthroughThe changes update the Changes
Suggested labels
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fab4eb8
to
0a214a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14566 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 1903 1903
Lines 24795 24795
Branches 2840 2840
=======================================
Hits 23733 23733
Misses 801 801
Partials 261 261 ☔ View full report in Codecov by Sentry. |
0a214a2
to
0dceed0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Updated allowed component types based on JSON schemas.
I’ve changed my mind since my comment in the issue, I now think it’s better to use an excluded component types list, as this will automatically support all future types (
Text
,Number
,Date
,Tabs
, etc.), while unsupported types will simply be ignored by the app frontend.Related Issue(s)
Verification
Summary by CodeRabbit
New Features
Refactor