Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query/mutation hooks for org code lists #14540

Merged
merged 20 commits into from
Feb 6, 2025

Conversation

ErlingHauan
Copy link
Contributor

@ErlingHauan ErlingHauan commented Jan 28, 2025

Description

Adds query/mutation hooks for org code lists.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@ErlingHauan ErlingHauan linked an issue Jan 28, 2025 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Jan 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. backend frontend labels Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (af0d8ec) to head (aa398fd).
Report is 3 commits behind head on org-library-mvp.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           org-library-mvp   #14540      +/-   ##
===================================================
+ Coverage            95.68%   95.72%   +0.03%     
===================================================
  Files                 1905     1913       +8     
  Lines                24803    24865      +62     
  Branches              2840     2840              
===================================================
+ Hits                 23733    23801      +68     
+ Misses                 809      803       -6     
  Partials               261      261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErlingHauan ErlingHauan changed the base branch from main to org-library-mvp January 28, 2025 20:20
@ErlingHauan ErlingHauan marked this pull request as ready for review January 28, 2025 20:22
@TomasEng TomasEng added team/studio-domain1 area/content-library Area: Related to library for shared resources labels Jan 29, 2025
@TomasEng TomasEng self-assigned this Jan 29, 2025
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette ser veldig bra ut, men det er noen småting jeg ville gjort litt annerledes. Se kommentarer.

Har du for øvrig gått gjennom sjekkboksene i PR-beskrivelsen?

@TomasEng TomasEng assigned ErlingHauan and unassigned TomasEng Jan 29, 2025
@ErlingHauan ErlingHauan requested a review from TomasEng January 31, 2025 08:34
@ErlingHauan ErlingHauan assigned TomasEng and unassigned ErlingHauan Jan 31, 2025
@TomasEng TomasEng removed their assignment Jan 31, 2025
@ErlingHauan
Copy link
Contributor Author

@TomasEng Jeg har opprettet en ny klasse i studio-pure-functions kalt FileUtils. Dette pga at samme kode ble brukt fire steder.

For å ikke gjøre PR-en enda større opprettet jeg også en ny issue #14565 , som handler om å eventuelt merge FileUtils og FileNameUtils.

@ErlingHauan ErlingHauan assigned TomasEng and unassigned ErlingHauan Feb 4, 2025
@ErlingHauan ErlingHauan added skip-releasenotes Issues that do not make sense to list in our release notes skip-documentation Issues where updating documentation is not relevant labels Feb 5, 2025
@ErlingHauan ErlingHauan changed the base branch from org-library-mvp to main February 5, 2025 11:26
@ErlingHauan ErlingHauan changed the base branch from main to org-library-mvp February 5, 2025 11:27
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liker FileUtils-klassen! Bare noen småting som gjenstår nå.

@TomasEng TomasEng added the skip-manual-testing PRs that do not need to be tested manually label Feb 6, 2025
@TomasEng
Copy link
Contributor

TomasEng commented Feb 6, 2025

Added the skip-manual-testing label since the hooks are not yet in use.

@TomasEng TomasEng merged commit 7533d17 into org-library-mvp Feb 6, 2025
9 checks passed
@TomasEng TomasEng deleted the 14505-react-query-hooks-for-code-lists branch February 6, 2025 08:52
@TomasEng TomasEng removed their assignment Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-preview Area: Related to test and preview of apps that are developed in Altinn Studio. area/content-library Area: Related to library for shared resources backend frontend quality/testing Tests that are missing, needs to be created or could be improved. skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

React Query hooks for code lists
2 participants