-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: query/mutation hooks for org code lists #14540
feat: query/mutation hooks for org code lists #14540
Conversation
…udio into 14505-react-query-hooks-for-code-lists
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## org-library-mvp #14540 +/- ##
===================================================
+ Coverage 95.68% 95.72% +0.03%
===================================================
Files 1905 1913 +8
Lines 24803 24865 +62
Branches 2840 2840
===================================================
+ Hits 23733 23801 +68
+ Misses 809 803 -6
Partials 261 261 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dette ser veldig bra ut, men det er noen småting jeg ville gjort litt annerledes. Se kommentarer.
Har du for øvrig gått gjennom sjekkboksene i PR-beskrivelsen?
frontend/packages/shared/src/hooks/mutations/useCreateOrgCodeListMutation.test.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useCreateOrgCodeListMutation.test.ts
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useCreateOrgCodeListMutation.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useDeleteOrgCodeListMutation.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useUpdateOrgCodeListMutation.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useUploadOrgCodeListMutation.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useCreateOrgCodeListMutation.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/queries/useOrgCodeListsQuery.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/queries/useOrgCodeListsQuery.test.ts
Outdated
Show resolved
Hide resolved
…udio into 14505-react-query-hooks-for-code-lists
…e render fn, begin improving caching)
…ub.com/Altinn/altinn-studio into 14505-react-query-hooks-for-code-lists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Liker FileUtils
-klassen! Bare noen småting som gjenstår nå.
frontend/packages/shared/src/hooks/mutations/useCreateOrgCodeListMutation.test.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useCreateOrgCodeListMutation.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useDeleteOrgCodeListMutation.test.ts
Outdated
Show resolved
Hide resolved
frontend/packages/shared/src/hooks/mutations/useUpdateOrgCodeListMutation.test.ts
Outdated
Show resolved
Hide resolved
…ub.com/Altinn/altinn-studio into 14505-react-query-hooks-for-code-lists
Added the |
Description
Adds query/mutation hooks for org code lists.
Related Issue(s)
Verification