Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add org-library and apps menu items and additional routing path #14539

Merged

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Jan 28, 2025

Description

Add an additional sub-route to be able to rename dashboard to home in the future. This creates a new abstraction level that will place the content-library for org-level on the same hierarchy as apps.
Menu items in header are added for both org-library and apps.

Skjermopptak.2025-01-30.kl.12.59.02.mov

Currently the sub route will not be set by default when rendering the dashboard - not sure where to change this? Probably in the load-balancer among other places? And maybe not something we want to change? Maybe dashboard should be changed to home with a gui and pressing the menu items will add the desired sub route.

Out of scope:

  • Adding css that marks a menu item as selected
  • Renaming dashboard to home
  • Create a landing page with the menu elements available in the main view
  • Handling what to display for a user that does not belong to any orgs
  • Handling what to display when a user tries to enter org library with self as context
  • Separate menu items for datamodel-apps and resources

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Copy link
Contributor

coderabbitai bot commented Jan 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.73%. Comparing base (7533d17) to head (bc9031a).
Report is 1 commits behind head on org-library-mvp.

Additional details and impacted files
@@               Coverage Diff                @@
##           org-library-mvp   #14539   +/-   ##
================================================
  Coverage            95.72%   95.73%           
================================================
  Files                 1915     1918    +3     
  Lines                24892    24936   +44     
  Branches              2840     2837    -3     
================================================
+ Hits                 23829    23872   +43     
  Misses                 802      802           
- Partials               261      262    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the add-sub-routes-and-menu-items-on-dashboard branch 2 times, most recently from f19a762 to 1d31524 Compare January 30, 2025 07:09
@standeren standeren force-pushed the add-sub-routes-and-menu-items-on-dashboard branch from 1d31524 to 765b2d1 Compare January 30, 2025 12:20
@standeren standeren marked this pull request as ready for review January 30, 2025 12:20
@TomasEng TomasEng added team/studio-domain1 area/content-library Area: Related to library for shared resources labels Jan 30, 2025
@standeren standeren force-pushed the add-sub-routes-and-menu-items-on-dashboard branch from 765b2d1 to db33af3 Compare January 30, 2025 13:15
@standeren standeren force-pushed the add-sub-routes-and-menu-items-on-dashboard branch 2 times, most recently from ada387a to 169dbe0 Compare January 30, 2025 13:52
@standeren standeren linked an issue Jan 31, 2025 that may be closed by this pull request
@standeren standeren force-pushed the add-sub-routes-and-menu-items-on-dashboard branch from 169dbe0 to cb08da6 Compare January 31, 2025 09:14
@standeren standeren force-pushed the add-sub-routes-and-menu-items-on-dashboard branch from cb08da6 to 1430db3 Compare January 31, 2025 09:18
@TomasEng TomasEng self-assigned this Jan 31, 2025
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fint at du fikk løst opp i rutingen! Jeg ser at vi har behov for å standardisere hvordan vi definerer ruter (nå er det mye frem og tilbake med hardkoding av skråstreker rundt omkring), men det får bli en annen sak.

@TomasEng TomasEng removed their assignment Feb 3, 2025
@ErlingHauan ErlingHauan self-assigned this Feb 3, 2025
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut!

Det eneste jeg kan sette fingeren på, er at menyelementene er mindre enn i app-development, og at valgt side ikke er understreket i menyen. Men styling skulle ikke omfavnes av denne PR-en, så det går bra.

Jeg og @Konrad-Simso har også testet denne lokalt, og finner ingen feil. Så jeg setter skip-manual-testing på denne.

@ErlingHauan ErlingHauan added the skip-manual-testing PRs that do not need to be tested manually label Feb 4, 2025
@ErlingHauan ErlingHauan assigned TomasEng and unassigned ErlingHauan Feb 4, 2025
@TomasEng TomasEng requested a review from ErlingHauan February 6, 2025 14:37
@TomasEng TomasEng assigned ErlingHauan and unassigned TomasEng Feb 6, 2025
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har sett over koden og re-testet lokalt. Ser veldig bra ut!

@ErlingHauan ErlingHauan merged commit 4c6fdbc into org-library-mvp Feb 7, 2025
8 checks passed
@ErlingHauan ErlingHauan deleted the add-sub-routes-and-menu-items-on-dashboard branch February 7, 2025 07:42
@TomasEng TomasEng restored the add-sub-routes-and-menu-items-on-dashboard branch February 7, 2025 07:50
@TomasEng TomasEng deleted the add-sub-routes-and-menu-items-on-dashboard branch February 7, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/content-library Area: Related to library for shared resources area/dashboard Area: Related to the dashboard application frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add a menu button for the org library
3 participants