chore: Remove feature flag accesspackages #14388
Conversation
…n in policy editor
github-actions
bot
added
solution/studio/designer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14388 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 1886 1889 +3
Lines 24546 24554 +8
Branches 2817 2817
=======================================
+ Hits 23479 23488 +9
Misses 805 805
+ Partials 262 261 -1 ☔ View full report in Codecov by Sentry. |
📝 WalkthroughWalkthroughThe pull request introduces changes to the policy editor and feature toggle utilities in the frontend package. Modifications include simplifying import statements, removing conditional rendering of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/packages/policy-editor/src/utils/index.ts (1)
67-67: LGTM! Added null safety for access packages.The fallback to an empty array ensures type safety and consistent behavior when access packages are undefined.
Consider adding a type guard or assertion to make the null check more explicit:
- accessPackages: r.accessPackages || [], + accessPackages: Array.isArray(r.accessPackages) ? r.accessPackages : [],
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackages.tsx(1 hunks)frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyRule.tsx(1 hunks)frontend/packages/policy-editor/src/utils/index.ts(1 hunks)frontend/packages/shared/src/utils/featureToggleUtils.ts(0 hunks)
💤 Files with no reviewable changes (1)
- frontend/packages/shared/src/utils/featureToggleUtils.ts
✅ Files skipped from review due to trivial changes (1)
- frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackages.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build environment and run e2e test
🔇 Additional comments (1)
frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyRule.tsx (1)
87-87: LGTM! Removal of feature flag for access packages.The unconditional rendering of
PolicyAccessPackagesaligns with the PR objective to enable access package selection in the policy editor.Let's verify that the component is properly integrated with its dependencies:
✅ Verification successful
Component integration verified successfully
The
PolicyAccessPackagescomponent shows proper integration with its dependencies, including comprehensive test coverage and clean architecture.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify PolicyAccessPackages component integration # Check for any potential circular dependencies or missing imports rg -l "PolicyAccessPackages" frontend/packages/policy-editor/src/Length of output: 2395
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackagesWarning.tsx (1)
11-44: Consider removing the empty string placeholder in the StudioLink.The component implementation looks good overall. However, there's an empty string placeholder (
{''}) within theStudioLinkcomponent that could be removed since it doesn't serve any purpose.- {''}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
frontend/language/src/nb.json(1 hunks)frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackages.tsx(3 hunks)frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackagesWarning.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackages.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build environment and run e2e test
- GitHub Check: CodeQL
- GitHub Check: Testing
🔇 Additional comments (2)
frontend/packages/policy-editor/src/components/PolicyCardRules/PolicyRule/PolicyAccessPackages/PolicyAccessPackagesWarning.tsx (1)
1-9: LGTM! Clean and well-organized imports.The imports are properly structured using named imports and grouped logically.
frontend/language/src/nb.json (1)
630-636: LGTM! Translations are clear and consistent.The translations effectively communicate:
- The transition from Altinn roles to access packages
- Timeline for the change (spring 2025)
- Important limitations and guidance for users
- Clear instructions for role selection
The translations align well with their usage in the
PolicyAccessPackagesWarningcomponent.
mgunnerud
added
the
skip-manual-testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Description
accessPackagesto release access package selection in policy editor for apps and resourcesRelated Issue(s)
Verification
Documentation
Summary by CodeRabbit
New Features
Refactor
AccessPackagesfeature flag.Bug Fixes
Documentation