-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Adjustments summary2 #14353
perf: Adjustments summary2 #14353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14353 +/- ##
=======================================
Coverage 95.54% 95.54%
=======================================
Files 1862 1863 +1
Lines 24125 24126 +1
Branches 2785 2782 -3
=======================================
+ Hits 23050 23051 +1
Misses 817 817
Partials 258 258 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the utils
refactoring 👍
I made some small comments:
.../ux-editor/src/components/config/componentSpecificContent/Summary2/Target/Summary2Target.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK in dev! 🚀
Description
Related Issue(s)
Verification
Documentation