Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Adjustments summary2 #14353

Merged
merged 13 commits into from
Jan 8, 2025
Merged

perf: Adjustments summary2 #14353

merged 13 commits into from
Jan 8, 2025

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Jan 3, 2025

Description

  • Display layout set names instead of their task IDs (subforms are excluded).
  • Moved the logic for target options of layout sets, pages, and components into a separate utility, simplifying tsx.

image

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Jan 3, 2025
@lassopicasso lassopicasso changed the title Adjustments summary2 perf: Adjustments summary2 Jan 3, 2025
@lassopicasso lassopicasso linked an issue Jan 3, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (1e059fd) to head (9b2efeb).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14353   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files        1862     1863    +1     
  Lines       24125    24126    +1     
  Branches     2785     2782    -3     
=======================================
+ Hits        23050    23051    +1     
  Misses        817      817           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso marked this pull request as ready for review January 3, 2025 13:03
@Jondyr Jondyr self-assigned this Jan 6, 2025
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the utils refactoring 👍
I made some small comments:

@Jondyr Jondyr removed their assignment Jan 6, 2025
@lassopicasso lassopicasso requested a review from Jondyr January 7, 2025 10:13
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK in dev! 🚀

@mlqn mlqn merged commit 5a38a96 into main Jan 8, 2025
17 checks passed
@mlqn mlqn deleted the adjustments-summary2 branch January 8, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace process tasks with layout sets in Summary2
3 participants