Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Added help text lines for RepeatingGroup and PaymentDetails #14344

Merged
merged 2 commits into from
Dec 31, 2024
Merged

refactor: Added help text lines for RepeatingGroup and PaymentDetails #14344

merged 2 commits into from
Dec 31, 2024

Conversation

Ildest
Copy link
Contributor

@Ildest Ildest commented Dec 30, 2024 •
edited
Loading

Note: Please review to see if I did this correctly, as it is my first time adding new lines to code.

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ildest Ildest linked an issue Dec 30, 2024 that may be closed by this pull request
Fix help texts #13691
Closed
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 30, 2024
@Ildest Ildest mentioned this pull request Dec 30, 2024
Closed
JamalAlabdullah
JamalAlabdullah approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice 👍 , I just fixed the place for the keys in nb file

@codecov Codecov
Copy link

codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (3db9af6) to head (6b59b50).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14344   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files        1841     1841           
  Lines       23880    23880           
  Branches     2755     2755           
=======================================
  Hits        22823    22823           
  Misses        800      800           
  Partials      257      257

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ildest
Copy link
Contributor Author

Ildest commented Dec 31, 2024

@lassopicasso would you like to do the second review, if you are working today?

lassopicasso
lassopicasso approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :) This can be merged now.

@lassopicasso lassopicasso merged commit a90cdff into main Dec 31, 2024
9 checks passed
@lassopicasso lassopicasso deleted the 13691-fix-help-texts-PR branch December 31, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassopicasso lassopicasso lassopicasso approved these changes

@JamalAlabdullah JamalAlabdullah JamalAlabdullah approved these changes

Assignees
No one assigned
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix help texts
3 participants
@Ildest @lassopicasso @JamalAlabdullah