Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow appmetadata to be undefined when validating name when data model is uploaded #14236

Merged

Conversation

standeren
Copy link
Contributor

Description

allow appMetadata to be undefined when validating name when data model is uploaded

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 6, 2024
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Great work!

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (3ab9086) to head (54e9131).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14236   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files        1817     1817           
  Lines       23652    23652           
  Branches     2735     2735           
=======================================
  Hits        22590    22590           
  Misses        808      808           
  Partials      254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad
Copy link
Member

nkylstad commented Dec 6, 2024

Testet OK i dev - opplasting av datamodell i datamodell repo fungerer nå som forventet.

@nkylstad nkylstad added the skip-manual-testing PRs that do not need to be tested manually label Dec 6, 2024
@nkylstad nkylstad merged commit 270057e into main Dec 6, 2024
18 checks passed
@nkylstad nkylstad deleted the allow-non-existent-appmetadata-when-validating-data-model-name branch December 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants