Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): open settings modal on redirect from ansattporten #14212

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Nov 29, 2024

Description

Added functionality to ensure the settings modal opens with the correct tab preselected when redirecting from Ansattporten. After login, users are seamlessly redirected to the appropriate section.

video_to_show.mp4

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@framitdavid framitdavid changed the title feat(settings): open settings modal on redirect from maskinporten feat(settings): open settings modal on redirect from ansattporten Nov 29, 2024
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 29, 2024
@framitdavid framitdavid marked this pull request as ready for review November 29, 2024 08:05
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (72c563a) to head (7b5c731).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14212   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files        1803     1803           
  Lines       23488    23494    +6     
  Branches     2719     2719           
=======================================
+ Hits        22422    22428    +6     
  Misses        812      812           
  Partials      254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Nov 29, 2024
@wrt95 wrt95 merged commit 579d9ce into main Nov 29, 2024
17 checks passed
@wrt95 wrt95 deleted the feat/openSettingsModalOnRedirect branch November 29, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants