Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding featureFlag for un-deploy #14198

Merged
merged 15 commits into from
Dec 10, 2024
Merged

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Nov 27, 2024

Description

  • Adding featureFlag for undeploy
  • Adding basic component

Related Issue(s)

Dependencies

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Nov 27, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 27, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.52%. Comparing base (3eb8149) to head (b63fa57).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...es/appPublish/components/DeploymentEnvironment.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14198      +/-   ##
==========================================
- Coverage   95.53%   95.52%   -0.01%     
==========================================
  Files        1824     1826       +2     
  Lines       23745    23757      +12     
  Branches     2751     2752       +1     
==========================================
+ Hits        22684    22695      +11     
  Misses        807      807              
- Partials      254      255       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95 wrt95 changed the title feature: adding featureFlag for un-deploy feat: adding featureFlag for un-deploy Nov 28, 2024
@framitdavid framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Dec 10, 2024
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@framitdavid framitdavid merged commit 37d92b5 into main Dec 10, 2024
10 of 11 checks passed
@framitdavid framitdavid deleted the 14192-featureflag-for-undeploy branch December 10, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up basic frontend with featureFlag and button to click
2 participants