Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 14125 implement full design of maskinporten #14148

Merged
merged 161 commits into from
Nov 26, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Nov 25, 2024

Description

  • Implementing full design for Maskinporten tab in SettingsModal.
  • Figma sketches

Images from this PR:

Not logged in with Ansattporten

Skjermbilde 2024-11-25 kl  12 43 31

No scopes available or selected

Skjermbilde 2024-11-25 kl  12 40 54

No scopes available for logged in user, but scopes are selected by someone else

Skjermbilde 2024-11-25 kl  12 43 02

Scopes available

Skjermbilde 2024-11-25 kl  12 42 01

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

framitdavid and others added 30 commits October 25, 2024 13:11
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 25, 2024
@wrt95 wrt95 linked an issue Nov 25, 2024 that may be closed by this pull request
@wrt95 wrt95 changed the title 14125 implement full design of maskinporten chore: 14125 implement full design of maskinporten Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (ab1a970) to head (e3f3ebc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14148      +/-   ##
==========================================
+ Coverage   95.33%   95.35%   +0.02%     
==========================================
  Files        1783     1794      +11     
  Lines       23230    23340     +110     
  Branches     2693     2699       +6     
==========================================
+ Hits        22147    22257     +110     
  Misses        836      836              
  Partials      247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Nov 26, 2024
@framitdavid
Copy link
Collaborator

Tested OK in dev.

@framitdavid framitdavid assigned wrt95 and unassigned framitdavid Nov 26, 2024
@framitdavid framitdavid merged commit c47e60f into main Nov 26, 2024
18 checks passed
@framitdavid framitdavid deleted the 14125-implement-full-design-of-maskinporten branch November 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new design for Maskinporten tab Pick one or more available scopes and save
3 participants