Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed Browserslist warnings by updating caniuse-lite database #14120

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix: Removed Browserslist warnings by updating caniuse-lite database #14120

merged 4 commits into from
Nov 25, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Nov 20, 2024 •
edited
Loading

Description

Removed Browserslist warnings generated when running yarn build by updating the caniuse-lite database

307609642-321c8aae-1aa4-4bec-813a-68caa0111508

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@mlqn mlqn marked this pull request as ready for review November 20, 2024 12:15
standeren
standeren approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 💯
Guess Renovate has not given us a headsup about this since it is only a dependency from another package we list in package.json? 😊

@mlqn mlqn added the skip-manual-testing PRs that do not need to be tested manually label Nov 22, 2024
@mlqn mlqn self-assigned this Nov 22, 2024
@mlqn
Copy link
Contributor Author

mlqn commented Nov 25, 2024

Yes, I guess. I didn't really think about it. I just ran the npx update-browserslist-db@latest command, as suggested in the warning 🤔

@mlqn
Copy link
Contributor Author

mlqn commented Nov 25, 2024

I added caniuse-lite to package.json. This should ensure automatic updates via Renovate

@mlqn mlqn requested a review from standeren November 25, 2024 12:24
@mlqn mlqn assigned standeren and unassigned mlqn Nov 25, 2024
standeren
standeren approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💯

@standeren standeren removed their assignment Nov 25, 2024
@mlqn mlqn merged commit 8dbbfc0 into main Nov 25, 2024
3 checks passed
@mlqn mlqn deleted the fix/caniuse-db-warning branch November 25, 2024 13:33
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
@mlqn @nkylstad
fix: Removed Browserslist warnings by updating caniuse-lite database (#…
c91ebdf 
…14120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@standeren standeren standeren approved these changes

Assignees
No one assigned
Labels
skip-manual-testing PRs that do not need to be tested manually team/studio-core team/studio-domain1 team/studio-domain2
Projects
Team Studio
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlqn @standeren