Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace table and checkbox with StudioCheckboxTable in accessControl tab #14112

Merged

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Nov 19, 2024

  • Replace Table and Checkbox with StudioCheckboxTable

Related Issue(s)

  • The PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 19, 2024
@wrt95 wrt95 added added-to-sprint team/studio-domain2 team/studio-core and removed solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Nov 19, 2024
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (1bd7f3f) to head (6505753).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14112   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files        1775     1775           
  Lines       23128    23128           
  Branches     2685     2685           
=======================================
+ Hits        22046    22047    +1     
+ Misses        834      833    -1     
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@framitdavid framitdavid self-assigned this Nov 20, 2024
@framitdavid
Copy link
Collaborator

Tested OK.

@framitdavid framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Nov 20, 2024
@framitdavid framitdavid merged commit 9616e61 into main Nov 20, 2024
11 checks passed
@framitdavid framitdavid deleted the replace-table-with-StudioCheckboxTable-in-accessControl-tab branch November 20, 2024 08:44
@wrt95 wrt95 assigned wrt95 and unassigned framitdavid Nov 20, 2024
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core team/studio-domain2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants