Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error when adding a component where the dataModelBindings property is missing #14070

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix: Error when adding a component where the dataModelBindings property is missing #14070

merged 4 commits into from
Nov 27, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Nov 14, 2024 •
edited
Loading

Description

Fixed error when adding a component where the dataModelBindings property is missing

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 14, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (707fe2c) to head (069f95c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14070      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files        1797     1797              
  Lines       23367    23366       -1     
  Branches     2702     2702              
==========================================
- Hits        22284    22283       -1     
  Misses        836      836              
  Partials      247      247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn linked an issue Nov 20, 2024 that may be closed by this pull request
Components with multiple data model bindings (e.g., Address) are missing #14103
Closed
@mlqn mlqn removed a link to an issue Nov 25, 2024
Components with multiple data model bindings (e.g., Address) are missing #14103
Closed
@mlqn mlqn linked an issue Nov 25, 2024 that may be closed by this pull request
Error when adding a component where the dataModelBindings property is missing #14152
Closed
@mlqn mlqn marked this pull request as ready for review November 25, 2024 13:13
@mlqn mlqn changed the title fix: Add missing null check fix: Error when adding a component where the dataModelBindings property is missing Nov 25, 2024
JamalAlabdullah
JamalAlabdullah approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and It works fine 👍

lassopicasso
lassopicasso approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev - works as expected :)

@mlqn mlqn merged commit c94ca60 into main Nov 27, 2024
10 checks passed
@mlqn mlqn deleted the fix/missing-null-check branch November 27, 2024 15:14
nkylstad pushed a commit that referenced this pull request Nov 28, 2024
@mlqn @lassopicasso @nkylstad
fix: Error when adding a component where the dataModelBindings prop…
091468f 
…erty is missing (#14070)

Co-authored-by: Lars <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassopicasso lassopicasso lassopicasso approved these changes

@JamalAlabdullah JamalAlabdullah JamalAlabdullah approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when adding a component where the dataModelBindings property is missing
3 participants
@mlqn @lassopicasso @JamalAlabdullah