feat: Implement modal to create new code list

[standeren]

Description

Skjermopptak.2024-11-08.kl.13.45.59.mov

FYI: Modal has fixed height, same as in ux-editor in code, but not in video ☝️

Related Issue(s)

• #{issue number}

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (460ceec) to head (feb871d).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14019   +/-   ##
=======================================
  Coverage   95.32%   95.33%           
=======================================
  Files        1780     1782    +2     
  Lines       23159    23202   +43     
  Branches     2689     2690    +1     
=======================================
+ Hits        22077    22120   +43     
  Misses        835      835           
  Partials      247      247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[ErlingHauan]

Nice work! I see that the saving UI pattern here differs from Utforming, where there is no save button, and changes are saved on close. Has this been discussed, or should we consider discussing it?

[standeren]

Nice work! I see that the saving UI pattern here differs from Utforming, where there is no save button, and changes are saved on close. Has this been discussed, or should we consider discussing it?

From what I understood after our meeting last week about saving patterns, I thought this was what we agreed upon 🙈 This is due to the filename has to be provided before the saving can be triggered. So we need a save button to control this interaction. However, when the .altinnstudio file can be taken advantage of, we will not need the save button anymore since we can save the codeList temporarily without a filename in that file 😄

[ErlingHauan]

Nice work! I see that the saving UI pattern here differs from Utforming, where there is no save button, and changes are saved on close. Has this been discussed, or should we consider discussing it?

From what I understood after our meeting last week about saving patterns, I thought this was what we agreed upon 🙈 This is due to the filename has to be provided before the saving can be triggered. So we need a save button to control this interaction. However, when the .altinnstudio file can be taken advantage of, we will not need the save button anymore since we can save the codeList temporarily without a filename in that file 😄

Sorry, it was not on close in Utforming, but on debounce for the manual editor at least 😅

My impression was that we would first try debounce, and if that could not be implemented, then try onBlur. And if that could not be implemented, have a save button. Just a suggestion, but it might be possible to have a handleSave function that uses debouncing, but it first checks that the name and codelist is valid before saving?

We could also wait until .altinnstudio is up and running, but not sure how long that is going to take 🤔

[standeren]

Nice work! I see that the saving UI pattern here differs from Utforming, where there is no save button, and changes are saved on close. Has this been discussed, or should we consider discussing it?

From what I understood after our meeting last week about saving patterns, I thought this was what we agreed upon 🙈 This is due to the filename has to be provided before the saving can be triggered. So we need a save button to control this interaction. However, when the .altinnstudio file can be taken advantage of, we will not need the save button anymore since we can save the codeList temporarily without a filename in that file 😄

Sorry, it was not on close in Utforming, but on debounce for the manual editor at least 😅

My impression was that we would first try debounce, and if that could not be implemented, then try onBlur. And if that could not be implemented, have a save button. Just a suggestion, but it might be possible to have a handleSave function that uses debouncing, but it first checks that the name and codelist is valid before saving?

We could also wait until .altinnstudio is up and running, but not sure how long that is going to take 🤔

Hm, yes, we could do that 🤔 But what if they add a fileName, add codelist content -> save is triggerd -> and then they change the filename ans the content before they close the modal? Then they will have saved multiple codelists? 🫣

[ErlingHauan]

Hm, yes, we could do that 🤔 But what if they add a fileName, add codelist content -> save is triggerd -> and then they change the filename ans the content before they close the modal? Then they will have saved multiple codelists? 🫣

Good point! The file handling would get more complicated. Then I agree with using a save button 😄

[TomasEng]

Testet OK.