Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Split ui-editor playwright tests into smaller tests #14008

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Nov 7, 2024

Description

  • The ui-editor Playwright test for ui-editor and data model bindings only had two large tests making the test slow on each time the PR ran Playwright tests. This PR splits the two large tests into smaller tests.

Related Issue(s)

  • PR itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. frontend labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (c9d1e52) to head (290d913).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14008   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files        1740     1740           
  Lines       22815    22815           
  Branches     2670     2670           
=======================================
  Hits        21722    21722           
  Misses        847      847           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Nov 7, 2024
@wrt95 wrt95 merged commit 22337dc into main Nov 7, 2024
10 checks passed
@wrt95 wrt95 deleted the refactor-playwright-tests-to-be-split-into-multiple-tests-instead-of-two branch November 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint frontend quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants