Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Delete primitives containers #13963

Merged
merged 4 commits into from
Nov 6, 2024
Merged

chore: Delete primitives containers #13963

merged 4 commits into from
Nov 6, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 31, 2024

Description

  • Deleting small almost unused components and adding the CSS where it was used

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Oct 31, 2024 that may be closed by this pull request
Delete /primities/index.tsx #13878
Closed
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/text-editor Area: Related to creating, translating and editing texts. area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (dee9f61) to head (d3117eb).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13963      +/-   ##
==========================================
- Coverage   95.23%   95.23%   -0.01%     
==========================================
  Files        1712     1712              
  Lines       22581    22572       -9     
  Branches     2642     2642              
==========================================
- Hits        21505    21496       -9     
  Misses        834      834              
  Partials      242      242

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jondyr
Jondyr approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@framitdavid
Copy link
Collaborator

Looks good! :D

@framitdavid framitdavid merged commit c79f104 into main Nov 6, 2024
10 checks passed
@framitdavid framitdavid deleted the 12878-delete-primitives branch November 6, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jondyr Jondyr Jondyr approved these changes

@framitdavid framitdavid framitdavid approved these changes

Assignees
No one assigned
Labels
area/dashboard Area: Related to the dashboard application area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/text-editor Area: Related to creating, translating and editing texts. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete /primities/index.tsx
3 participants
@wrt95 @framitdavid @Jondyr