Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace divider component #13960

Merged
merged 13 commits into from
Nov 7, 2024
Merged

chore: Replace divider component #13960

merged 13 commits into from
Nov 7, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 31, 2024

Description

  • Deleting <Divider /> component.
  • Replacing all occurrences with studio-token

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Oct 31, 2024 that may be closed by this pull request
Replace all occurrences of Divider with border-bottom: solid {X} px {color} #13877
Closed
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 31, 2024
@wrt95 wrt95 changed the title Replace divider component chore: Replace divider component Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.20%. Comparing base (a702c6c) to head (60a481c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...r/src/components/TypesInspector/TypesInspector.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13960   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files        1738     1740    +2     
  Lines       22814    22815    +1     
  Branches     2671     2670    -1     
=======================================
+ Hits        21721    21722    +1     
  Misses        847      847           
  Partials      246      246

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

standeren
standeren requested changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ⭐

@wrt95 wrt95 requested a review from standeren November 5, 2024 10:56
standeren
standeren approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

ErlingHauan
ErlingHauan approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

Looks good!

@ErlingHauan ErlingHauan merged commit c9d1e52 into main Nov 7, 2024
16 checks passed
@ErlingHauan ErlingHauan deleted the Replace-Divider-component branch November 7, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@standeren standeren standeren approved these changes

@ErlingHauan ErlingHauan ErlingHauan approved these changes

Assignees
No one assigned
Labels
area/dashboard Area: Related to the dashboard application area/data-modeling Area: Related to data models - e.g. create, edit, use data models. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace all occurrences of Divider with border-bottom: solid {X} px {color}
3 participants
@wrt95 @standeren @ErlingHauan