Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(process): ensure layoutset is added when adding signing task #13934

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

nkylstad
Copy link
Member

Description

As per the documentation of the signing task, a layoutset needs to be associated with the task.
Updated the handlers that handle adding tasks to the process to add a layoutset for the signing task.
Also ensure that the RecommendedNextAction for naming layoutset is shown in this case.

Future: We could automatically add the signing button, in the same way that we add the payment component for payment layoutset. However, I am leaving that to a later PR.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 28, 2024
@nkylstad nkylstad changed the title esure layoutset is added when adding signing task fix(process-editor): esure layoutset is added when adding signing task Oct 28, 2024
@nkylstad nkylstad changed the title fix(process-editor): esure layoutset is added when adding signing task fix(process-editor): ensure layoutset is added when adding signing task Oct 28, 2024
@nkylstad nkylstad changed the title fix(process-editor): ensure layoutset is added when adding signing task fix(process): ensure layoutset is added when adding signing task Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (dae7a6b) to head (b347945).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...packages/process-editor/src/hooks/useBpmnEditor.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13934   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files        1673     1673           
  Lines       22189    22191    +2     
  Branches     2608     2609    +1     
=======================================
+ Hits        21109    21111    +2     
  Misses        834      834           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Oct 28, 2024
@nkylstad nkylstad added the skip-manual-testing PRs that do not need to be tested manually label Oct 28, 2024
@nkylstad
Copy link
Member Author

Tested this manually in dev.

@nkylstad nkylstad merged commit 34fd4d4 into main Oct 28, 2024
9 of 10 checks passed
@nkylstad nkylstad deleted the fix(process-editor)/add-layoutset-onAdd-signing-task branch October 28, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). frontend quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants