-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(process): ensure layoutset is added when adding signing task #13934
Merged
nkylstad
merged 3 commits into
main
from
fix(process-editor)/add-layoutset-onAdd-signing-task
Oct 28, 2024
Merged
fix(process): ensure layoutset is added when adding signing task #13934
nkylstad
merged 3 commits into
main
from
fix(process-editor)/add-layoutset-onAdd-signing-task
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
framitdavid
approved these changes
Oct 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13934 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 1673 1673
Lines 22189 22191 +2
Branches 2608 2609 +1
=======================================
+ Hits 21109 21111 +2
Misses 834 834
Partials 246 246 ☔ View full report in Codecov by Sentry. |
Tested this manually in dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/process
Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc).
frontend
quality/testing
Tests that are missing, needs to be created or could be improved.
skip-manual-testing
PRs that do not need to be tested manually
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the documentation of the signing task, a layoutset needs to be associated with the task.
Updated the handlers that handle adding tasks to the process to add a layoutset for the signing task.
Also ensure that the RecommendedNextAction for naming layoutset is shown in this case.
Future: We could automatically add the signing button, in the same way that we add the payment component for payment layoutset. However, I am leaving that to a later PR.
Verification
Documentation