-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement StudioCodeListEditor in component edit view #13922
feat: Implement StudioCodeListEditor in component edit view #13922
Conversation
…3505-implement-studiocodelisteditor-in-component-edit-view
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13922 +/- ##
==========================================
- Coverage 95.20% 95.20% -0.01%
==========================================
Files 1740 1747 +7
Lines 22828 22876 +48
Branches 2672 2676 +4
==========================================
+ Hits 21733 21778 +45
- Misses 849 850 +1
- Partials 246 248 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dette er veldig bra. EditOptions
begynner å bli ganske stor og kompleks. Hva tenker du om å benytte anledningen til å rydde opp der?
Ellers lurer jeg på om det er nødvendig å bruke debounce
her. Det er mulig jeg tar feil, men så vidt jeg vet er dette allerede satt opp på et høyere nivå, og da bør det være tilstrekkelig. Hvis det likevel er nødvendig, ville jeg satt opp Timer Mocks i testene for å unngå at de bare står og venter.
Ellers må du gjerne gå over funksjonene du har laget og sette på returtyper. Dette er en regel vi egentlig burde hatt linting på, men vi har ikke satt det opp fordi det er så mye gammel kode som ikke følger regelen.
...nts/config/editModal/EditOptions/EditManualOptionsWithEditor/EditManualOptionsWithEditor.tsx
Outdated
Show resolved
Hide resolved
...nts/config/editModal/EditOptions/EditManualOptionsWithEditor/EditManualOptionsWithEditor.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditOptions/EditOptions.tsx
Outdated
Show resolved
Hide resolved
...ckages/ux-editor/src/components/config/editModal/EditOptions/hooks/useCodeListButtonValue.ts
Outdated
Show resolved
Hide resolved
...ckages/ux-editor/src/components/config/editModal/EditOptions/hooks/useCodeListButtonValue.ts
Outdated
Show resolved
Hide resolved
...ckages/ux-editor/src/components/config/editModal/EditOptions/hooks/useCodeListEditorTexts.ts
Outdated
Show resolved
Hide resolved
...nts/config/editModal/EditOptions/EditManualOptionsWithEditor/EditManualOptionsWithEditor.tsx
Outdated
Show resolved
Hide resolved
...onfig/editModal/EditOptions/EditManualOptionsWithEditor/EditManualOptionsWithEditor.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditOptions/EditOptions.module.css
Outdated
Show resolved
Hide resolved
…ocodelisteditor-in-component-edit-view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed texts with a couple of suggestions
Co-authored-by: Gørild Døhl <[email protected]>
Co-authored-by: Gørild Døhl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK! 🚀
…ocodelisteditor-in-component-edit-view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
Description
StudioCodeListEditor
component in the "manual" tab. Use&featureFlags=codeListEditor
to enable it.StudioCodeListEditor
.Moved an alert inside the component in the manual tab, since it's only displayed there.Edit:
Related Issue(s)
Video
Spiller.inn.2024-10-30.155233.mp4
Edit: The modal now has a fixed height.
Verification