Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete PageContainer #13906

Merged
merged 8 commits into from
Nov 6, 2024
Merged

chore: Delete PageContainer #13906

merged 8 commits into from
Nov 6, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 24, 2024

Description

  • Component is only used 2 places and is only a div with css. The css has been moved to usage place and component deleted.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Oct 24, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. area/studio-root Area: Issues related to studio-root application area/overview Area: Related to the overview page frontend labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (3d9bf61) to head (89dcc7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13906   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files        1711     1712    +1     
  Lines       22579    22581    +2     
  Branches     2642     2642           
=======================================
+ Hits        21503    21505    +2     
  Misses        834      834           
  Partials      242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that it was a little more CSS duplication than just the page width. Please look into my comment and give me some feedback on what you think. 😊

@wrt95 wrt95 requested a review from framitdavid October 28, 2024 11:27
@wrt95 wrt95 requested a review from framitdavid October 31, 2024 13:31
@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Nov 6, 2024
@wrt95 wrt95 merged commit dee9f61 into main Nov 6, 2024
10 checks passed
@wrt95 wrt95 deleted the 13858-Delete-PageContainer branch November 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/overview Area: Related to the overview page area/studio-root Area: Issues related to studio-root application frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete PageContainer
2 participants