Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Rename subForm to subform #13903

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Oct 24, 2024

Description

Renaming folders, files and code from subForm/SubForm to subform/Subform.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@lassopicasso lassopicasso linked an issue Oct 24, 2024 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 24, 2024
@lassopicasso lassopicasso changed the title Rename sub form to subform style: Rename sub form to subform Oct 24, 2024
@lassopicasso lassopicasso changed the title style: Rename sub form to subform style: Rename subForm to subform Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (4f52f21) to head (f749397).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tend/packages/ux-editor/src/data/formItemConfig.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13903   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files        1673     1673           
  Lines       22189    22189           
  Branches     2608     2608           
=======================================
  Hits        21109    21109           
  Misses        834      834           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso marked this pull request as ready for review October 24, 2024 11:02
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok in dev 🙂

@JamalAlabdullah JamalAlabdullah merged commit dae7a6b into main Oct 28, 2024
9 checks passed
@JamalAlabdullah JamalAlabdullah deleted the rename-subForm-to-subform branch October 28, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace subForm with subform
3 participants