Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subform): texts to inform user invalid subform layout #13834

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Oct 21, 2024

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Jondyr added 19 commits October 14, 2024 14:59
…-texts-to-inform-user-that-they-must-configure-subform
…-texts-to-inform-user-that-they-must-configure-subform
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (51ce6ed) to head (c62ce68).
Report is 1 commits behind head on 10-17-add_subformmissingcontentwarning_component.

Additional details and impacted files
@@                                Coverage Diff                                @@
##           10-17-add_subformmissingcontentwarning_component   #13834   +/-   ##
=================================================================================
  Coverage                                             95.30%   95.30%           
=================================================================================
  Files                                                  1650     1651    +1     
  Lines                                                 21975    21991   +16     
  Branches                                               2581     2583    +2     
=================================================================================
+ Hits                                                  20943    20959   +16     
  Misses                                                  787      787           
  Partials                                                245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr changed the title 13682 texts to inform user invalid subform layout feat: texts to inform user invalid subform layout Oct 21, 2024
@Jondyr Jondyr changed the title feat: texts to inform user invalid subform layout feat(subform): texts to inform user invalid subform layout Oct 21, 2024
@Jondyr Jondyr changed the base branch from main to 10-17-add_subformmissingcontentwarning_component October 21, 2024 10:49
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🙂 I just commented a small things,
and also wonder if we can add a space between the header and the warning message.

image

@Jondyr Jondyr force-pushed the 13682-texts-to-inform-user-invalid-subform-layout branch from b3ac41c to cf66567 Compare October 23, 2024 10:47
Co-authored-by: JamalAlabdullah <[email protected]>
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig bra 😊

@lassopicasso lassopicasso merged commit fd3a672 into 10-17-add_subformmissingcontentwarning_component Oct 24, 2024
15 checks passed
@lassopicasso lassopicasso deleted the 13682-texts-to-inform-user-invalid-subform-layout branch October 24, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
3 participants