Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no value option to edit string value ux-editor #13807

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 16, 2024

Description

  • Added an option for when no value is set. The user can just select that value to remove their selection.

image
image

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@wrt95 wrt95 linked an issue Oct 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (2f17f0a) to head (e57182f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13807   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files        1635     1635           
  Lines       21828    21836    +8     
  Branches     2567     2568    +1     
=======================================
+ Hits        20796    20804    +8     
  Misses        787      787           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev - works as expected 🥳

@lassopicasso lassopicasso merged commit 3283838 into main Oct 18, 2024
17 checks passed
@lassopicasso lassopicasso deleted the 13166-feat-add-no-value-option-to-string-value branch October 18, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to remove currency formatting from "Kort svar"
3 participants