Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement basic design for empty content library #13805

Merged

Conversation

standeren
Copy link
Contributor

Description

Implements the content-library, with a landingpage and empty pages for codeLists and images, to be used in the app-development service. It can be accessed by adding /content-library to the url for an app in designer.

Skjermbilde 2024-10-16 kl  14 13 22

Skjermbilde 2024-10-16 kl  14 13 34

Skjermbilde 2024-10-16 kl  14 13 47

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren linked an issue Oct 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend kind/dependencies Used for issues or pull requests that are dependency updates frontend labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (1b47df6) to head (aba1f76).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13805      +/-   ##
==========================================
+ Coverage   94.59%   94.62%   +0.02%     
==========================================
  Files        1630     1647      +17     
  Lines       21894    21992      +98     
  Branches     2573     2582       +9     
==========================================
+ Hits        20711    20809      +98     
  Misses        940      940              
  Partials      243      243              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Annikenkbrathen
Copy link

I see that things are progressing quickly, and the same goes for the sketching. This front page of the library appears when the user opens the library, but once you click to a new page, you don’t have the option to go back to the front page. This is poor UX design on my part, and something I missed. The settings modal doesn’t have a front page but takes you to the first item in the "About the App" column when you open the modal.

Possible solutions:

  1. Make the "Library" title clickable so the user can click it to view the front page.
  2. Add a page called "About the Library" in the left-hand column.
  3. Remove the front page entirely.

Personally, I’m leaning towards option 2 to follow the same pattern as the settings modal.

Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😄 I saw some possible changes and made suggestions.

As for the comment by Anniken about the UX design.
The current solution fulfills option 1. I think it's good as a first iteration, and if there is going to be a redesign of the library, then changes can be implemented in a second iteration.

Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

@standeren standeren merged commit acda247 into main Oct 25, 2024
15 checks passed
@standeren standeren deleted the 13707-implement-basic-design-for-empty-content-library branch October 25, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend frontend kind/dependencies Used for issues or pull requests that are dependency updates solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement basic design for empty content library
4 participants