-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement basic design for empty content library #13805
feat: implement basic design for empty content library #13805
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13805 +/- ##
==========================================
+ Coverage 94.59% 94.62% +0.02%
==========================================
Files 1630 1647 +17
Lines 21894 21992 +98
Branches 2573 2582 +9
==========================================
+ Hits 20711 20809 +98
Misses 940 940
Partials 243 243 ☔ View full report in Codecov by Sentry. |
I see that things are progressing quickly, and the same goes for the sketching. This front page of the library appears when the user opens the library, but once you click to a new page, you don’t have the option to go back to the front page. This is poor UX design on my part, and something I missed. The settings modal doesn’t have a front page but takes you to the first item in the "About the App" column when you open the modal. Possible solutions:
Personally, I’m leaning towards option 2 to follow the same pattern as the settings modal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 😄 I saw some possible changes and made suggestions.
As for the comment by Anniken about the UX design.
The current solution fulfills option 1. I think it's good as a first iteration, and if there is going to be a redesign of the library, then changes can be implemented in a second iteration.
frontend/libs/studio-content-library/src/ContentLibrary/LibraryHeader/LibraryHeader.module.css
Outdated
Show resolved
Hide resolved
frontend/libs/studio-content-library/src/ContentLibrary/pages/CodeList/CodeList.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-content-library/src/ContentLibrary/pages/Images/Images.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-content-library/src/ContentLibrary/PagesRouter/PagesRouter.test.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-content-library/src/ContentLibrary/PagesRouter/PagesRouter.test.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-content-library/src/ContentLibrary/PagesRouter/PagesRouter.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 💯
Description
Implements the content-library, with a landingpage and empty pages for codeLists and images, to be used in the app-development service. It can be accessed by adding
/content-library
to the url for an app in designer.Related Issue(s)
Verification