fix(workspace): update the logging guard to handle ConnectionString for Application Insights #13792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontend + added unit-tests for it
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
added
solution/studio/designer
framitdavid
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13792 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 1623 1624 +1
Lines 21798 21817 +19
Branches 2570 2572 +2
=======================================
+ Hits 20616 20634 +18
- Misses 939 940 +1
Partials 243 243 ☔ View full report in Codecov by Sentry. |
framitdavid
added
skip-manual-testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tested ok, browser errors are once again being logged in AI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue with the logging guard in our application. The guard previously checked for the presence of the
instrumentationKey, but we recently switched to using aconnectionStringwithout updating the guard logic. As a result, the guard always evaluated as true for the absence ofinstrumentationKey, which led to Application Insights instances never being created.Related Issue(s)
Verification