Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated default component help text #13781

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Oct 14, 2024

Description

The default (fallback) helptext for components referred to the text for the CustomButton component.

  • Added the helptext for CustomComponent and used the text from default
  • Updated the default text to something more generic.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 14, 2024
@nkylstad nkylstad added kind/bug Used when there is a defect / something is not working as it should. added-to-sprint labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (f6f6b7e) to head (6f1eee1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13781   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files        1623     1623           
  Lines       21798    21798           
  Branches     2570     2570           
=======================================
  Hits        20616    20616           
  Misses        939      939           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Oct 14, 2024
@wrt95 wrt95 merged commit 9636841 into main Oct 14, 2024
15 checks passed
@wrt95 wrt95 deleted the fix/13691-fix-default-helptext branch October 14, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint frontend kind/bug Used when there is a defect / something is not working as it should. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants