-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix error that occurs when dragging a type into an object #13762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13762 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 1623 1623
Lines 21797 21800 +3
Branches 2570 2570
=======================================
+ Hits 20615 20618 +3
Misses 939 939
Partials 243 243 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fungerer som det skal i test. Bra fiks!
Description
This pull request fixes an error that occurs when dragging a type into an object in our data modelling tool. This happened because the
useAddRreference
hook referenced the target parent withuniquePointer
instead ofschemaPointer
. This pull request corrects that, in additon to add measures to prevent it from happening again. Here is a list of the changes:useAddReference
useAddReference
hookgetUniquePointer
andremoveUniquePointerPrefix
methods on theSchemaModel
class static, since they don't depend onthis
How to reproduce the error in production
Spiller.inn.2024-10-10.133616.mp4
Verification