-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 13526 support component specific overrides in summary2 #13734
feat: 13526 support component specific overrides in summary2 #13734
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13734 +/- ##
=======================================
Coverage 95.27% 95.27%
=======================================
Files 1635 1638 +3
Lines 21828 21867 +39
Branches 2567 2573 +6
=======================================
+ Hits 20796 20834 +38
Misses 787 787
- Partials 245 246 +1 ☔ View full report in Codecov by Sentry. |
…ry2' of https://github.com/Altinn/altinn-studio into feat13526-support-component-specific-overrides-in-summary2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Jamal! 👏
I've added some comments 😄
...components/config/componentSpecificContent/Summary2/Override/Summary2OverrideDisplaytype.tsx
Outdated
Show resolved
Hide resolved
...components/config/componentSpecificContent/Summary2/Override/Summary2OverrideDisplaytype.tsx
Outdated
Show resolved
Hide resolved
...components/config/componentSpecificContent/Summary2/Override/Summary2OverrideDisplaytype.tsx
Outdated
Show resolved
Hide resolved
...components/config/componentSpecificContent/Summary2/Override/Summary2OverrideDisplaytype.tsx
Outdated
Show resolved
Hide resolved
...r/src/components/config/componentSpecificContent/Summary2/Override/Summary2OverrideEntry.tsx
Outdated
Show resolved
Hide resolved
...src/components/config/componentSpecificContent/Summary2/Override/hook/useCustomConfigType.ts
Outdated
Show resolved
Hide resolved
...r/src/components/config/componentSpecificContent/Summary2/Override/Summary2OverrideEntry.tsx
Outdated
Show resolved
Hide resolved
...r/src/components/config/componentSpecificContent/Summary2/Override/Summary2OverrideEntry.tsx
Outdated
Show resolved
Hide resolved
...components/config/componentSpecificContent/Summary2/Override/Summary2OverrideDisplaytype.tsx
Outdated
Show resolved
Hide resolved
…ry2' of https://github.com/Altinn/altinn-studio into feat13526-support-component-specific-overrides-in-summary2
...packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Override/utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @JamalAlabdullah! 👏 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works without any issues 🎉
But i have one question; for group overrides, the documentation states:
In addition, a few components support component-specific overrides:
isCompact [...] Option to display a compact version of groups.
ref. https://docs.altinn.studio/altinn-studio/reference/ux/components/summary2/
Which i interpret as allowing an override on a whole group container, but the current solution seems to enable this field for components inside a group.
I'm wondering if this is a confusion about containers/components, or if this is the intended behaviour?
The isCompact
override does not seem to have any effect on the summary2 component in the preview, from my testing.
Nice catch, @Jondyr! That’s correct, the isCompact should be on the group component itself. But my understanding, team apps will be supporting isCompact as a global config later (not sure when), but for now it’s only the group component as a container. 😀 |
…ry2' of https://github.com/Altinn/altinn-studio into feat13526-support-component-specific-overrides-in-summary2
@framitdavid @Jondyr I have changed the logic to check against the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Tested and works well ✅
I have a question about a code change though:
…ry2' of https://github.com/Altinn/altinn-studio into feat13526-support-component-specific-overrides-in-summary2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Description
These changes are behind the featureflag summary2
Changes:
(string, list, not set
) when the summary is for acheckbox
ormultiselect
component.isCompact
) when the summary is for a component that is inside a group component.Related Issue(s)
Verification
Documentation