Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 13555 fix latest commit link #13672

Merged
merged 12 commits into from
Oct 18, 2024
Merged

Conversation

JamalAlabdullah
Copy link
Contributor

Description

  • Fixed the redirect link to the last commit so that it opens when the user copies it by right-clicking and tries to open it in another browser.
  • Added a new component called LatestCommit
  • Added test.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Oct 1, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Oct 1, 2024
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 💯 Some changes requested

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (4d92115) to head (6272e43).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13672   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files        1644     1645    +1     
  Lines       21929    21937    +8     
  Branches     2580     2581    +1     
=======================================
+ Hits        20897    20905    +8     
  Misses        787      787           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Fixed my own comments since @JamalAlabdullah is not responsable for this issue anymore as it belongs to domain 1.
Feel free to assign me to the issue if there is any test-feedback!

Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some testing in Firefox:

  1. Created a new app with an Input component
  2. Built the first version of the app
  3. Went to Gitea, and changed the text resource for the Inputs label
  4. Pulled the changes in Studio
  5. Hovered over the link siste endringstransaksjon til master, which has the URL https://altinn.studio/editor/org/app/latest-commit
  6. Clicked the link. It correctly took me to the latest commit. However, there is an in-between period where the error toast shows briefly.
  7. Opened the link in new tab and new window. This also works, but the error toast is still present.

It's a nice improvement, but can we fix the error toast?
It seems to only be visible in the /latest-commit route.

Spiller.inn.2024-10-15.122842.mp4

@ErlingHauan
Copy link
Contributor

@standeren
Re-tested, and the issue still persists with Firefox:

Spiller.inn.2024-10-17.100347.mp4

In Chrome, the toast is gone, but here the StudioHeader disappears and reappears before redirecting, creating a sort of flashing effect. Would it be possible to either not show the header when loading, or keep the header in place all the time?
But now we are in nitpicking territory 😅

Spiller.inn.2024-10-17.100627.mp4

@ErlingHauan ErlingHauan assigned standeren and unassigned standeren Oct 17, 2024
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK

@standeren standeren merged commit 6013fdd into main Oct 18, 2024
10 checks passed
@standeren standeren deleted the feat/13555-fix-latest-commit-link branch October 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect url to Gitea in Deploy page.
4 participants