-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 13555 fix latest commit link #13672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix 💯 Some changes requested
frontend/app-development/features/latestCommit/LatestCommit.tsx
Outdated
Show resolved
Hide resolved
frontend/app-development/features/latestCommit/LatestCommit.test.tsx
Outdated
Show resolved
Hide resolved
frontend/app-development/features/latestCommit/LatestCommit.test.tsx
Outdated
Show resolved
Hide resolved
frontend/app-development/features/latestCommit/LatestCommit.test.tsx
Outdated
Show resolved
Hide resolved
frontend/app-development/features/latestCommit/LatestCommit.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13672 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 1644 1645 +1
Lines 21929 21937 +8
Branches 2580 2581 +1
=======================================
+ Hits 20897 20905 +8
Misses 787 787
Partials 245 245 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Fixed my own comments since @JamalAlabdullah is not responsable for this issue anymore as it belongs to domain 1.
Feel free to assign me to the issue if there is any test-feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some testing in Firefox:
- Created a new app with an Input component
- Built the first version of the app
- Went to Gitea, and changed the text resource for the Inputs label
- Pulled the changes in Studio
- Hovered over the link
siste endringstransaksjon til master
, which has the URLhttps://altinn.studio/editor/org/app/latest-commit
- Clicked the link. It correctly took me to the latest commit. However, there is an in-between period where the error toast shows briefly.
- Opened the link in new tab and new window. This also works, but the error toast is still present.
It's a nice improvement, but can we fix the error toast?
It seems to only be visible in the /latest-commit
route.
Spiller.inn.2024-10-15.122842.mp4
@standeren Spiller.inn.2024-10-17.100347.mp4In Chrome, the toast is gone, but here the StudioHeader disappears and reappears before redirecting, creating a sort of flashing effect. Would it be possible to either not show the header when loading, or keep the header in place all the time? Spiller.inn.2024-10-17.100627.mp4 |
…ath that does not use PageLayout element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test OK
Description
LatestCommit
Related Issue(s)
Verification
Documentation