feat: enable certmanager for dis-apim-operator

[tjololo]

Description

Dis operator has a mutating webhook and needs a certificate provided by cert-manager. This change should add the neccessary resources according

Related Issue(s)

• #{issue number}

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)
• All tests run green

Documentation

• User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

• New Features
  • Activated secure certificate management enhancements to improve certificate authority injection.
  • Enabled secure webhook service configurations that streamline and strengthen certificate handling.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change activates previously commented configuration in the kustomization file for the dis-apim-operator. It brings the certmanager resource into active use, enables replacements for CA injection annotations on both ValidatingWebhookConfiguration and MutatingWebhookConfiguration, and activates service settings for the webhook-service. These modifications allow the operator to manage certificate-related configurations and webhook services as part of its deployment.

Changes

File	Change Summary
services/dis-apim-operator/config/.../kustomization.yaml	- Uncommented certmanager resource inclusion - Activated replacement blocks for ValidatingWebhookConfiguration and MutatingWebhookConfiguration - Enabled service configurations for webhook-service

Suggested reviewers

• bengtfredh

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19f9e32 and 0c55916.

📒 Files selected for processing (1)

• services/dis-apim-operator/config/default/kustomization.yaml (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Run on Ubuntu
• GitHub Check: Run on Ubuntu
• GitHub Check: Analyze (go)

🔇 Additional comments (7)

services/dis-apim-operator/config/default/kustomization.yaml (7)

25-25: Activate cert-manager resource.
The uncommented ../certmanager resource in the resources list now enables cert-manager integration for certificate management. Please verify that the referenced path is correct and that the corresponding cert-manager manifests exist.

---

50-65: Enable CA Injection for ValidatingWebhookConfiguration (Block 1).
This block reactivates CA injection by mapping the Certificate’s .metadata.namespace into the cert-manager.io/inject-ca-from annotation on ValidatingWebhookConfiguration with index 0. Please ensure that the expected annotation key and value are correctly handled by your webhook configuration.

---

66-80: Enable CA Injection for ValidatingWebhookConfiguration (Block 2).
This block supplements the previous configuration by mapping the Certificate’s .metadata.name into the cert-manager.io/inject-ca-from annotation with index 1. Verify that using both namespace and name as distinct sources meets your CA injection requirements for the ValidatingWebhookConfiguration.

---

82-97: Enable CA Injection for MutatingWebhookConfiguration (Block 1).
This segment activates CA injection for the MutatingWebhookConfiguration by mapping the Certificate’s .metadata.namespace field. Ensure that this approach aligns properly with the expected annotation on your mutating webhook and that it does not conflict with your other configuration settings.

---

98-111: Enable CA Injection for MutatingWebhookConfiguration (Block 2).
This block configures CA injection for the MutatingWebhookConfiguration by taking the Certificate’s .metadata.name field and injecting it into the webhook’s annotations (index 1). Please check that both blocks for the mutating webhook work in tandem and that the order (indexes 0 and 1) is correctly interpreted by the deployment.

---

144-160: Activate cert-manager Replacement for webhook-service (Block 1).
This block maps the webhook-service’s .metadata.name to certificate DNS names (index 0) under the Certificate configuration. Confirm that the designated fieldPath and the index used correctly point to the intended DNS name in your service configuration.

---

161-177: Activate cert-manager Replacement for webhook-service (Block 2).
This segment maps the webhook-service’s .metadata.namespace to the Certificate resource for DNS names (index 1). Ensure that this second replacement, together with the previous one, covers all intended DNS entries and that the delimiter '.' and indexing accurately reflect your service’s configuration setup.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.