Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional values.rbac to deploy rbac resources #1316

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

Salec
Copy link
Contributor

@Salec Salec commented Jan 27, 2024

Signed-off-by: Fernando Martin [email protected]

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

Why

Current helm operator chart assumes that you are able to create the ClusterRole and ClusterRoleBinding.

This PR hopes to give control to installers who lack those permissions in their cluster.

@Slach
Copy link
Collaborator

Slach commented Jan 27, 2024

Thanks for your contribution.
Looks like we already have serviceAccount.create value. And your adding just allow our more flexible control.

@Slach Slach merged commit 23c7da6 into Altinity:0.23.0 Jan 27, 2024
Slach added a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants