-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate operator helm chart #1049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but small cosmetic comments
and main concern
if we generate grafana dashboards
could we add optional dependency to Chart.yaml for this use case
@@ -0,0 +1,83 @@ | |||
{{/* vim: set filetype=mustache: */}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we change it to go-template?
…h call to go_build_all.sh Signed-off-by: Slach <[email protected]>
Signed-off-by: Slach <[email protected]>
AIM of this PR is to migrate altinity-clickhouse-operator chart to the official repo.
PR contains a lot of auto-generated files, so it makes sense to review commits individually.
Things yet to cover:
./dev/generate_helm_chart.sh
after the script that generatesdeploy/operator/clickhouse-operator-install-bundle.yaml
Sample of the release pipeline: https://github.com/slamdev/clickhouse-operator/actions/runs/3455712508/jobs/5767926291
Chart archive is attached to a release: https://github.com/slamdev/clickhouse-operator/releases/tag/release-0.20.0
Autogenerated index.yaml: https://github.com/slamdev/clickhouse-operator/blob/gh-pages/index.yaml
Chart is available via github pages:
Prerequisite: create
gh-pages
branch and make sure it's empty.Actions after the first chart release:
closes #1024 #941 #837 #620
partially solves #558