Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate operator helm chart #1049

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Generate operator helm chart #1049

merged 7 commits into from
Dec 7, 2022

Conversation

slamdev
Copy link
Contributor

@slamdev slamdev commented Nov 13, 2022

AIM of this PR is to migrate altinity-clickhouse-operator chart to the official repo.

PR contains a lot of auto-generated files, so it makes sense to review commits individually.

Things yet to cover:

  • run ./dev/generate_helm_chart.sh after the script that generates deploy/operator/clickhouse-operator-install-bundle.yaml

Sample of the release pipeline: https://github.com/slamdev/clickhouse-operator/actions/runs/3455712508/jobs/5767926291

Chart archive is attached to a release: https://github.com/slamdev/clickhouse-operator/releases/tag/release-0.20.0

Autogenerated index.yaml: https://github.com/slamdev/clickhouse-operator/blob/gh-pages/index.yaml

Chart is available via github pages:

helm show chart altinity-clickhouse-operator --repo=https://slamdev.github.io/clickhouse-operator

apiVersion: v2
appVersion: 0.20.0
description: Helm chart to deploy [altinity-clickhouse-operator](https://github.com/Altinity/clickhouse-operator).  The
  ClickHouse Operator creates, configures and manages ClickHouse clusters running
  on Kubernetes.
home: https://github.com/Altinity/clickhouse-operator
icon: https://altinity.com/wp-content/uploads/2022/05/logo_horizontal_blue_white.svg
maintainers:
- email: [email protected]
  name: altinity
name: altinity-clickhouse-operator
type: application
version: 0.20.0

Prerequisite: create gh-pages branch and make sure it's empty.

Actions after the first chart release:

closes #1024 #941 #837 #620
partially solves #558

@slamdev slamdev marked this pull request as ready for review November 13, 2022 14:59
@Slach Slach self-requested a review November 16, 2022 10:32
@Slach Slach changed the base branch from master to 0.20.1 November 16, 2022 10:35
Copy link
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but small cosmetic comments

and main concern
if we generate grafana dashboards
could we add optional dependency to Chart.yaml for this use case

@@ -0,0 +1,83 @@
{{/* vim: set filetype=mustache: */}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we change it to go-template?

@Slach Slach merged commit d5077c7 into Altinity:0.20.1 Dec 7, 2022
Slach added a commit that referenced this pull request Dec 7, 2022
Slach added a commit that referenced this pull request Dec 12, 2022
Signed-off-by: Slach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm generate issue
2 participants