Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 705 tests #714

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Issue 705 tests #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
000ad35
Update,
antip00 Jan 27, 2025
4aa11a8
Update.
antip00 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/testflows/steps/panel/view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,15 +688,15 @@ def save_dashboard(self):
click_save_confirmation_button()

@TestStep(When)
def check_no_labels(self, labels):
def check_no_labels_on_visualization(self, labels):
"""Check there is no labels in the panel."""

for label in labels:
with By(f"searching for label {label}"):
try:
ui.wait_for_element_to_be_visible(
select_type=SelectBy.XPATH,
element=f'//*[contains(text(), "{label}")]'
element=f'//*[@data-viz-panel-key]//*[contains(text(), "{label}")]'
)
return False
except:
Expand Down
2 changes: 1 addition & 1 deletion tests/testflows/tests/automated/e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def many_categories(self):

with Then("I check there is no errors on the visualization"):
with delay():
assert panel.check_no_labels(labels=["normalized_query_hash", "Too many points"]), error()
assert panel.check_no_labels_on_visualization(labels=["normalized_query_hash", "Too many points"]), error()
finally:
with Finally("I discard changes for panel"):
with delay():
Expand Down
Loading