Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables query editor #713

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Variables query editor #713

merged 4 commits into from
Jan 27, 2025

Conversation

lunaticusgreen
Copy link
Collaborator

@lunaticusgreen lunaticusgreen commented Jan 26, 2025 •
edited by Slach
Loading

fix #614

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12979446483

Details

  • 51 of 52 (98.08%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 76.559%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/views/QueryEditor/components/QueryTextEditor/hooks/useQueryHandlers.ts 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
src/datasource/sql-query/sql-query-helper.ts 1 68.49%
src/datasource/scanner/scanner.ts 1 80.9%
src/datasource/datasource.ts 5 51.73%
Totals Coverage Status
Change from base Build 12950819689: -0.2%
Covered Lines: 3556
Relevant Lines: 4479
💛 - Coveralls

@Slach Slach added this to the 3.4.0 milestone Jan 27, 2025
@Slach Slach merged commit f36c00c into master Jan 27, 2025
3 checks passed
@Slach Slach mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Better template variable UX
3 participants
@lunaticusgreen @coveralls @Slach