Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adhoc hide table names connection settings option, #698

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Add adhoc hide table names connection settings option, #698

merged 3 commits into from
Dec 26, 2024

Conversation

Slach
Copy link
Collaborator

@Slach Slach commented Dec 25, 2024

fix #456

@Slach Slach requested a review from lunaticusgreen December 25, 2024 14:15
@Slach Slach added this to the 3.3.1 milestone Dec 25, 2024
@Slach
fix tests for #456
1c63d01 
Signed-off-by: Eugene Klimov <[email protected]>
@coveralls
Copy link

coveralls commented Dec 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12503725353

Details

  • 13 of 33 (39.39%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 76.153%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/datasource/adhoc.ts 12 32 37.5%
Totals Coverage Status
Change from base Build 12482109295: -0.3%
Covered Lines: 3539
Relevant Lines: 4461
💛 - Coveralls

@Slach Slach merged commit f50a961 into master Dec 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunaticusgreen lunaticusgreen Awaiting requested review from lunaticusgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Allow hiding the table.colname fields from ad-hoc filters
2 participants
@Slach @coveralls