Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TRACE and Flamegraph formats #508

Closed
Slach opened this issue Jan 17, 2024 · 7 comments · Fixed by #539
Closed

Support TRACE and Flamegraph formats #508

Slach opened this issue Jan 17, 2024 · 7 comments · Fixed by #539
Assignees
@lunaticusgreen
Labels
p1 Priority 1
Milestone
3.1.0

Comments

@Slach
Copy link
Collaborator

Slach commented Jan 17, 2024 •
edited
Loading

Current supported format

  • Time series
  • Table
  • Logs
    image

need to add

  • Trace format for properly show traceability data system.telemetry_span_log for example
  • Flamegraph format for properly show flamegraph like pyroscope and tempo
@Slach Slach added this to the 3.0.1 milestone Jan 17, 2024
@Slach Slach changed the title Support TRACE format Support TRACE and Flamegraph formats Jan 25, 2024
@svb-alt svb-alt added the p1 Priority 1 label Apr 1, 2024
@Slach Slach mentioned this issue Apr 1, 2024
Closed
Slach added a commit that referenced this issue Apr 14, 2024
@Slach
WIP, try to add support for Flamegraph and Tracing, look details in #508
c82c731
Slach added a commit that referenced this issue Apr 18, 2024
@Slach
add ORDER BY tracing query, #508
c2c688e
@Slach Slach mentioned this issue Apr 22, 2024
Merged
@Slach Slach reopened this Apr 22, 2024
@Slach
Copy link
Collaborator Author

Slach commented Apr 22, 2024

still need some improvements

Slach added a commit that referenced this issue Apr 22, 2024
@Slach
improve FlameGraph and Tracing description in README.md, see #508
bebe982
@Slach
Copy link
Collaborator Author

Slach commented Apr 22, 2024

Just add current implementation details

Format as: Traces

Tracing Example

Format as: Flame Graph

Flame Graph example

@Slach
Copy link
Collaborator Author

Slach commented Apr 22, 2024

@lunaticusgreen
what is it bug or expected behavior?
image

@Slach
Copy link
Collaborator Author

Slach commented Apr 22, 2024

@lunaticusgreen
wrong error handling
image

image

@Slach
Copy link
Collaborator Author

Slach commented Apr 22, 2024

@lunaticusgreen why so many gray stack traces?

image

@Slach
Copy link
Collaborator Author

Slach commented Apr 22, 2024

@lunaticusgreen tracing related issue
traceID button always copy the same traceID value

image

image

but data contains different TraceID (look to after export)

 jq .batches[].instrumentationLibrarySpans[].spans[].traceId "Trace-478cd9-2024-04-22 12_03_45.json" |
 uniq -c | sort
      9 "511ad96f-7da1-85eb-2d99-a5058ca74efc"
      9 "75cbfe3f-5d0a-9683-8f04-4546aca41963"
      9 "81c52f0a-be38-1cd4-7a45-a1654565b72c"
      9 "f5fef918-9d8e-7491-1619-ff8c59478cd9"
     12 "36cbb5d3-0489-703c-94f8-1bcd30fa5d77"
     29 "96f371ea-b61b-7bf3-7773-7b0d6e8f07a7"

@Slach
Copy link
Collaborator Author

Slach commented Apr 22, 2024

@lunaticusgreen
image
could we control deep link behavior?
deeplink open explore
but query is wrong

image

maybe we could change something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lunaticusgreen lunaticusgreen

Labels
p1 Priority 1
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Implement Flamegraphs and Traces functionality Altinity/clickhouse-grafana
3 participants
@Slach @lunaticusgreen @svb-alt