Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the SQL highlighted is not supported for Grafana 7.x #381

Closed
frank-lam opened this issue Nov 11, 2021 · 3 comments · Fixed by #387
Closed

the SQL highlighted is not supported for Grafana 7.x #381

frank-lam opened this issue Nov 11, 2021 · 3 comments · Fixed by #387
Milestone
2.4.0

Comments

@frank-lam
Copy link

frank-lam commented Nov 11, 2021 •
edited
Loading

like this, lack of syntax highlighting affects the experience. Hope to fix this BUG as soon as possible

But I did support syntax highlighting when I used Grafana 5.x
@frank-lam frank-lam changed the title Highlighting is not supported for Grafana 7.x SQL Highlighting is not supported for Grafana 7.x Nov 11, 2021
@frank-lam frank-lam changed the title SQL Highlighting is not supported for Grafana 7.x the SQL highlighted is not supported for Grafana 7.x Nov 11, 2021
@Slach
Copy link
Collaborator

Slach commented Nov 11, 2021

old bug which not related with grafana version, duplicate with
#174

just reload page

@Slach Slach closed this as completed Nov 11, 2021
@frank-lam
Copy link
Author

@Slach
reload the page doesn't work either. will this be fixed in the next version?

@Slach
Copy link
Collaborator

Slach commented Nov 12, 2021

@frank-lam I can't find root cause,

https://github.com/Vertamedia/clickhouse-grafana/blob/master/src/query_ctrl.ts#L9
should always try to import mode-clickhouse.js as part of dist/module.js after compilation

if you can help, please feel free to make pull request

@Slach Slach added this to the 2.4.0 milestone Nov 29, 2021
@Slach Slach mentioned this issue Nov 29, 2021
Merged
Slach added a commit to Altinity/grafana-plugin-repository that referenced this issue Nov 29, 2021
@Slach
ClickHouse database datasource plugin update to 2.4.0
a501296 
# 2.4.0 (2021-11-29)

## Enhancement:
* Add support for Grafana 8.x unified alerts, fix Altinity/clickhouse-grafana#380
* Add TLS support for backend alerts part of plugin Altinity/clickhouse-grafana#356 (comment)
* Add $naturalTimeSeries macro, look details in https://github.com/Vertamedia/clickhouse-grafana/pull/89/files#diff-cd9133eda7b58ef9c9264190db4534a1be53216edbda9ac57256fbd800368c03R383-R412
* Update golang-plugin-sdk-go to latest version
* Properly format Value in Table format, look details Altinity/clickhouse-grafana#379
* Remove toDateTime64 casting for column when time column is already DateTime64 to improve performance. Change test to ensure the casting is removed from the query, fix Altinity/clickhouse-grafana#360
* implements `$timeFilter64ByColumn(column_name)` macro, fix Altinity/clickhouse-grafana#343

## Fixes:

* implements properly GET and POST support for alert queries, fix Altinity/clickhouse-grafana#353
* SQL syntax highlight now works always, fix Altinity/clickhouse-grafana#174, fix Altinity/clickhouse-grafana#381
* fix Altinity/clickhouse-grafana#376,
* fix negative behavior for $perSecondColumns Altinity/clickhouse-grafana#337
* fix Altinity/clickhouse-grafana#374, ignore `--` inside quotas as comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

prepare release 2.4.0
2 participants
@Slach @frank-lam